Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert() method on the bond #17

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Conversation

luckyrobot
Copy link

@luckyrobot luckyrobot commented Mar 24, 2022

closes #13

this is to convert bonds only, and it fixes the max supply button

showing previews will be a new pr, from #17 (comment)

@vercel
Copy link

vercel bot commented Mar 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/porter-finance/frontend-ido/8PkPdEKXF5dJ2tVccHppuf3TNiNy
✅ Preview: https://frontend-ido-git-convert-method-on-the-bond-porter-finance.vercel.app

@luckyrobot luckyrobot marked this pull request as ready for review March 24, 2022 21:31
@luckyrobot luckyrobot enabled auto-merge (squash) March 24, 2022 21:31
@luckyrobot luckyrobot enabled auto-merge (squash) March 24, 2022 21:31
@luckyrobot luckyrobot requested a review from RusseII March 24, 2022 21:33
@RusseII
Copy link
Contributor

RusseII commented Mar 24, 2022

In the future - the input boxes will probably be disabled as well if the buttons are disabled

clicking max should populate the input with total number of bond tokens the user has
@luckyrobot luckyrobot merged commit 02f5ec4 into main Mar 25, 2022
@luckyrobot luckyrobot deleted the convert()-method-on-the-bond branch April 20, 2022 12:49
Geczy added a commit that referenced this pull request May 7, 2022
Geczy added a commit that referenced this pull request May 7, 2022
Geczy added a commit that referenced this pull request May 7, 2022
Geczy pushed a commit that referenced this pull request May 7, 2022
Geczy added a commit that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants