New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1136 sdk split #89

Merged

tomteman merged 11 commits into develop from 1136-sdk-split

Mar 17, 2021

Contributor

gh-23378 commented Feb 22, 2021 •

edited

Loading

PR divides the SDK between web3 related functionality and widget communication functionality to prepare for the introduction of a new starkware provider component

PR should avoid introducing breaking API changes
certain public methods and properties have been removed because their use was never meant to be supported (top level widgetInstance for example)
note that cryptopuppers (in the Portis repo) will not currently work with the SDK because it was relying on hidden APIs which have been removed. See https://github.com/portis-project/portis/blob/982ab916d7dd5abcdaaff1ef1aebb51ccb15e4a2/apps/portis-crypto-puppers/src/services/web3.ts#L158

katien and others added 7 commits

February 15, 2021 19:58


          saving progress on sdk split, things do not currently compile and no …

0732e87

…new functionality has been added


          finished splitting SDK logic between web3 and widget - testing needed

b294bce


          Fixed import paths to make SDK buildable.

c86224a


          Added support for source map by setting the PORTIS_BUILD_SOURCE_MAPS …

3878bbc

…environment variable.


          Passing config to web3Manager to unbreak.

9be6c3f


          getWidgetCommunication method fixed

e928e53


          rename config interface because it is shared across widget and web3, …

…make a few methods static on widgetmanager

gh-23378 requested review from mimafogeus2 and tomteman

February 22, 2021 20:27

tomteman reviewed

View reviewed changes

packages/portis-web3/src/web3/web3Manager.ts Outdated Show resolved Hide resolved

packages/portis-web3/src/widget/widgetManager.ts Outdated Show resolved Hide resolved

packages/portis-web3/src/widget/widgetManager.ts Outdated Show resolved Hide resolved

packages/portis-web3/src/widget/widgetManager.ts Outdated Show resolved Hide resolved


          expose web3provider via getter and config as top level property on sdk

47afb3b

mimafogeus2 reviewed

View reviewed changes

packages/portis-web3/src/interfaces.ts Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts

+                      return;
+                    }
+                    let result: any = null;

Contributor

mimafogeus2 Mar 1, 2021

Is result really any?

packages/portis-web3/src/web3/web3Manager.ts

+                        break;
+                      case 'eth_uninstallFilter':
+                        this.engine.sendAsync(payload, _ => _);

Contributor

mimafogeus2 Mar 1, 2021

Is the second argument necessary?

packages/portis-web3/src/web3/web3Manager.ts Outdated Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts Outdated Show resolved Hide resolved

packages/portis-web3/src/web3/web3Manager.ts Show resolved Hide resolved

katien added 3 commits

March 2, 2021 10:11


          respond to tom's PR feedback

066ed44


          respond to a subset of miki's comments as he is a HIGHLY demanding pe…

d1f131f

…rson


          increment version to 4 because we may have breaking changes

7af0fef

tomteman reviewed

View reviewed changes

packages/portis-web3/src/web3/web3Manager.ts

+              export default class Web3Manager {
+                private engine: ProviderEngine;
+                provider;

Contributor

tomteman Mar 15, 2021

I think 'provider' should be private, no?

mimafogeus2 changed the base branch from master to develop

March 16, 2021 12:51

tomteman approved these changes

View reviewed changes

tomteman merged commit 075245a into develop

tomteman added a commit that referenced this pull request


          Upgrading master to 4.0.0 (#104)

209b2a1

* 1136 sdk split (#89)

* saving progress on sdk split, things do not currently compile and no new functionality has been added

* finished splitting SDK logic between web3 and widget - testing needed

* Fixed import paths to make SDK buildable.

* Added support for source map by setting the PORTIS_BUILD_SOURCE_MAPS environment variable.

* Passing config to web3Manager to unbreak.

* getWidgetCommunication method fixed

* rename config interface because it is shared across widget and web3, make a few methods static on widgetmanager

* expose web3provider via getter and config as top level property on sdk

* respond to tom's PR feedback

* respond to a subset of miki's comments as he is a HIGHLY demanding person

* increment version to 4 because we may have breaking changes

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* HOTFIX: SSR fix now doesn't have typing problems. (#97)

* HOTFIX: SSR fix now doesn't have typing problems.

* TEMP

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Task: Configure TS to work in strict mode, to minimize risks of braking other projects. (#98)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* BUGFIX: Exposed methods were unbound, which could lead to unwanted edge cases. (#93)

This:
```
const showWidget = portis.showWidget;
showWidget();
```
wouldn't work, because `showWidget` isn't run from within `portis`, and thus its `this` wouldn't be `portis`.

Thanks @KatieN for finding this out.

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>
Co-authored-by: mimafogeus2 <github@foge.us>

tomteman added a commit that referenced this pull request


          Master (#106)

81d8ff9

* Upgrading master to 4.0.0 (#104)

* 1136 sdk split (#89)

* saving progress on sdk split, things do not currently compile and no new functionality has been added

* finished splitting SDK logic between web3 and widget - testing needed

* Fixed import paths to make SDK buildable.

* Added support for source map by setting the PORTIS_BUILD_SOURCE_MAPS environment variable.

* Passing config to web3Manager to unbreak.

* getWidgetCommunication method fixed

* rename config interface because it is shared across widget and web3, make a few methods static on widgetmanager

* expose web3provider via getter and config as top level property on sdk

* respond to tom's PR feedback

* respond to a subset of miki's comments as he is a HIGHLY demanding person

* increment version to 4 because we may have breaking changes

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* HOTFIX: SSR fix now doesn't have typing problems. (#97)

* HOTFIX: SSR fix now doesn't have typing problems.

* TEMP

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Task: Configure TS to work in strict mode, to minimize risks of braking other projects. (#98)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* BUGFIX: Exposed methods were unbound, which could lead to unwanted edge cases. (#93)

This:
```
const showWidget = portis.showWidget;
showWidget();
```
wouldn't work, because `showWidget` isn't run from within `portis`, and thus its `this` wouldn't be `portis`.

Thanks @KatieN for finding this out.

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>
Co-authored-by: mimafogeus2 <github@foge.us>

* HOTFIX: Fixed bug where Portis was unable to sign typed data v3 messages. (#105)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

Co-authored-by: Tom Teman <tomteman42@gmail.com>
Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

tomteman added a commit that referenced this pull request


          Merging develop into master (#120)

c60e06e

* 1136 sdk split (#89)

* saving progress on sdk split, things do not currently compile and no new functionality has been added

* finished splitting SDK logic between web3 and widget - testing needed

* Fixed import paths to make SDK buildable.

* Added support for source map by setting the PORTIS_BUILD_SOURCE_MAPS environment variable.

* Passing config to web3Manager to unbreak.

* getWidgetCommunication method fixed

* rename config interface because it is shared across widget and web3, make a few methods static on widgetmanager

* expose web3provider via getter and config as top level property on sdk

* respond to tom's PR feedback

* respond to a subset of miki's comments as he is a HIGHLY demanding person

* increment version to 4 because we may have breaking changes

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* HOTFIX: SSR fix now doesn't have typing problems. (#97)

* HOTFIX: SSR fix now doesn't have typing problems.

* TEMP

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Task: Configure TS to work in strict mode, to minimize risks of braking other projects. (#98)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* BUGFIX: Exposed methods were unbound, which could lead to unwanted edge cases. (#93)

This:
```
const showWidget = portis.showWidget;
showWidget();
```
wouldn't work, because `showWidget` isn't run from within `portis`, and thus its `this` wouldn't be `portis`.

Thanks @KatieN for finding this out.

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Master (#106)

* Upgrading master to 4.0.0 (#104)

* 1136 sdk split (#89)

* saving progress on sdk split, things do not currently compile and no new functionality has been added

* finished splitting SDK logic between web3 and widget - testing needed

* Fixed import paths to make SDK buildable.

* Added support for source map by setting the PORTIS_BUILD_SOURCE_MAPS environment variable.

* Passing config to web3Manager to unbreak.

* getWidgetCommunication method fixed

* rename config interface because it is shared across widget and web3, make a few methods static on widgetmanager

* expose web3provider via getter and config as top level property on sdk

* respond to tom's PR feedback

* respond to a subset of miki's comments as he is a HIGHLY demanding person

* increment version to 4 because we may have breaking changes

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* HOTFIX: SSR fix now doesn't have typing problems. (#97)

* HOTFIX: SSR fix now doesn't have typing problems.

* TEMP

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Task: Configure TS to work in strict mode, to minimize risks of braking other projects. (#98)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* BUGFIX: Exposed methods were unbound, which could lead to unwanted edge cases. (#93)

This:
```
const showWidget = portis.showWidget;
showWidget();
```
wouldn't work, because `showWidget` isn't run from within `portis`, and thus its `this` wouldn't be `portis`.

Thanks @KatieN for finding this out.

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>
Co-authored-by: mimafogeus2 <github@foge.us>

* HOTFIX: Fixed bug where Portis was unable to sign typed data v3 messages. (#105)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

Co-authored-by: Tom Teman <tomteman42@gmail.com>
Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* 2677 campaign details (#113)

* create getCampaignInfo sdk method, call into widget is breaking build

* create getCampaignInfo sdk method, call into widget is breaking build

* string interface workaround to fix build

* 2652 claim voucher (#116)

* claimvoucher sdk method

* pass ISDKConfig when claiming voucher (FULL METHOD requires it)

* Revert "pass ISDKConfig when claiming voucher (FULL METHOD requires it)"

This reverts commit 164e1f7.

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Tom Teman <tomteman42@gmail.com>

Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Tom Teman <tomteman42@gmail.com>

* Removed portis-eos, moved portis-web3 to main dir (#117)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Added version deploy CircleCI config. (#119)

Co-authored-by: Miki Stanger <miki.stanger@portis.io>

* Bumping version to 4.0.2

Co-authored-by: Katie Noland <katienoland9@gmail.com>
Co-authored-by: katien <katien.nol@shapeshift.io>
Co-authored-by: Miki Stanger <miki.stanger@portis.io>
Co-authored-by: mimafogeus2 <github@foge.us>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet