-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for volume driver to run on OCS #1958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn-px
changed the title
Adding support for volume driver to run OCS (kdmp)
Adding support for volume driver to run OCS
Dec 11, 2023
sn-px
changed the title
Adding support for volume driver to run OCS
Adding support for volume driver to run on OCS
Dec 11, 2023
kphalgun-px
reviewed
Dec 11, 2023
kphalgun-px
reviewed
Dec 11, 2023
kphalgun-px
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mkoppal-px
reviewed
Dec 15, 2023
mkoppal-px
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kshithijiyer-px
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding support for volume driver to run OCS (kdmp)
Which issue(s) this PR fixes (optional)
Closes #https://portworx.atlassian.net/browse/PB-5161
Special notes for your reviewer:
https://aetos.pwx.purestorage.com/resultSet/testSetID/466584
https://jenkins.pwx.dev.purestorage.com/job/Users/job/santoshn/job/ocs-byoc/18/console
Latest log : https://jenkins.pwx.dev.purestorage.com/job/Users/job/santoshn/job/ocs-byoc/20/