Predict completion for go mod edit -replace #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Feb 20, 2019
| return nil | ||
| } | ||
| data, _ := json.Marshal(&fkd) | ||
| ioutil.WriteFile(fmt.Sprintf("%s/go-gomod-replace-dsts-%d", os.TempDir(), ppid), data, os.ModePerm) |
There was a problem hiding this comment.
Error return value of ioutil.WriteFile is not checked (from errcheck)
| if err != nil { | ||
| log.Printf("regex err %v\n", err) | ||
| } else { | ||
| err = filepath.Walk(fd.Name(), func(path string, info os.FileInfo, err error) error { |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
|
Is this WIP? |
|
Since there was no reply, I'm closing this. Please reopen if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code needs a tidy up (too many nested ifs).
Completes
go mod edit -replace old@oldv=new@newv.oldis populated fromgo mod edt -jsonoldvnot implementednewif path (~or../or/) then walks the directories looking for go.mod, checks that themoduleif equalsoldadds it to the predictions.newif no path then used the github api to get list of forked projects.newvis currently only set to master.