Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated stopwatch to use restart #192

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

jamesbr-ashn
Copy link
Contributor

@jamesbr-ashn jamesbr-ashn commented Nov 21, 2019

Description

Restart allows the timer to keep going, whereas reset stops the timer. This update will implement a backend ping every 5 seconds instead of having a single backend ping occur.

Related Issue

#191

Motivation and Context

It fixes the code to follow the logic presented by the code itself and inline comments

How Has This Been Tested?

Made the change directly to an installed module that was being debugged

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Restart allows the timer to keep going, whereas reset stops the timer. This update will implement a backend ping every 5 seconds instead of having a single backend ping.
@devblackops devblackops merged commit 3c43f46 into poshbotio:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants