Data Explorer: Make sure we update the data shape after a Data Update #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
force-pushed
the
bugfix/schema-update
branch
from
2cc4f8f
to
8e6ffeb
Compare
juliasilge
approved these changes
Aug 20, 2024
dfalbel
force-pushed
the
bugfix/schema-update
branch
from
6039c80
to
02170f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#4286
When we verify if there was a data change in R, we check if we should send a SchemaChange or a DataUpdate event.
When the schema changes, ie, types of columns or number of columns, we would correctly update the data shape.
For data updates we would skip this update, however it's necessary because even though the schema didn't change, it's possible that the number of rows has changed and we need to make sure the front-end knows about that.