Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plots test to Windows Workflow #4951

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Add Plots test to Windows Workflow #4951

merged 7 commits into from
Oct 8, 2024

Conversation

jonvanausdeln
Copy link
Contributor

@jonvanausdeln jonvanausdeln commented Oct 8, 2024 •
edited
Loading

Intent

Part of addressing #4867 adds plots tests

Approach

  • Had to modify some to expand various panes to be visible
  • Had to modify the simplePlotTest to make pane visible
  • Plots that compare to known good are skipped because the windows diff are too great. we could later add some OS specific base images, but ROI not worth it now.
  • Save plots skipped because the save dialog overflows the screen.

QA Notes

Windows & Linux Nightly runs works as expected.

@jonvanausdeln jonvanausdeln self-assigned this Oct 8, 2024
@jonvanausdeln jonvanausdeln changed the title Add More tests to windows workflow Add Plots test to Windows Workflow Oct 8, 2024
@jonvanausdeln jonvanausdeln marked this pull request as ready for review October 8, 2024 21:45
testlabauto
testlabauto approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ubuntu looks good!

@jonvanausdeln jonvanausdeln merged commit 9c57708 into main Oct 8, 2024
6 of 7 checks passed
@jonvanausdeln jonvanausdeln deleted the jonv-add-windows-tests branch October 8, 2024 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@testlabauto testlabauto testlabauto approved these changes

@midleman midleman Awaiting requested review from midleman

Assignees

@jonvanausdeln jonvanausdeln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonvanausdeln @testlabauto