Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type annotation of
_add_ws
frombool
toTagAttrValue
. Even though the value must still actually be abool
, this change simplifies writing functions that pass alongkwargs
.For example, previously pyright would flag this as an error, because the
kwargs
could include_add_ws
, but the former is aTagAttrValue
while the latter is abool
:In order to satisfy the type checker, you previously would have to write this:
After this PR, the first version of the code is not flagged as an error by the type checker. If a non-bool is passed to
_add_ws
, there will be a run-time error.