Make Tag objects usable as context managers #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used as a context manager, upon exit, the tag displays itself.
|
Ideally I'd want to use IPython.core.display but that seems like a heavy dependency to take, if we can get 95% of the way by doing something simpler in htmltools/shiny. |
wch
reviewed
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used as a context manager, upon exit, the tag displays itself.
TODO: Currently, the tag just appends its "children" to itself. This is probably too simplistic. We need to decide how this code, Shiny Express's top-level, and
@display_body/@render.displaygo from sys.displayhook to UI, hopefully in a unified way.Note: CI tests are failing because I intentionally left a type error in 👆 part of the code.