Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feat): rewrite to TypeScript #186

Closed

Conversation

aleclarson
Copy link

@aleclarson aleclarson commented Mar 23, 2024

First, let me state that I don't expect you to actually review this (of course, if you do, awesome!). Looking over 62 changed files, 5k additions, and 11.5k deletions at the time of writing from a stranger is a daunting task, and you may not even care to have this library moved to TypeScript (no problem at all!).

Notes

  • Caveat: I removed the docs generation (and other stuff), which makes this PR a non-starter in its current state. Of course, it could be added back, though I have no incentive to spend time on that at the moment. Apologies for that!
  • You are free to take this and do with it what you want. Of course, I'd be happy to get this merged so I don't have to rebase your future work, but the trade-offs make that hard for me as of now.
  • All that said, I wanted to share my incomplete work just in case it might help you (or another contributor) finish the transition, if that's a desired outcome.

Thanks for your time! Happy coding.

@andris9
Copy link
Collaborator

andris9 commented Mar 24, 2024

You should probably fork the module for TypeScript if you have already done all the work. I have no plans to adopt TS myself for my libraries.

@andris9 andris9 closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants