Add warning message for deprecated addDependencyTo option #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,6 +63,9 @@ function AtImport(options) { | |||
| typeof options.addDependencyTo === "object" && | |||
| typeof options.addDependencyTo.addDependency === "function" | |||
| ) { | |||
| console.warn( | |||
There was a problem hiding this comment.
@RyanZim addDependencyTo is deprecated in favour of result.messages.dependency, postcss-loader >= v1.0.0 will automatically add your imported files to webpack's file watcher. For more information consider https://github.com/postcss/postcss-import#dependency-message-support
http://api.postcss.org/Result.html#warn additionally or as replacement. postcss-loader will emit a warning about it then.
There was a problem hiding this comment.
But let @ai approve it first 😛
|
Logic looks fine. But @michael-ciniawsky suggested better text. |
|
@ai Will update text; you're fine with |
|
Yeap |
RyanZim
force-pushed
the
addDependencyTo
branch
from
bb981ae
to
0def127
Compare
|
@ai Fixed; had to do some pretty bad formatting to keep eslint happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ai Not sure if this is done right.