Skip to content

Commit

Permalink
Add warning message for deprecated addDependencyTo option (#251)
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanZim authored Nov 29, 2016
1 parent 9fdde94 commit dfe4c23
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 28 deletions.
8 changes: 8 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ function AtImport(options) {
typeof options.addDependencyTo === "object" &&
typeof options.addDependencyTo.addDependency === "function"
) {
console.warn([
"addDependencyTo is deprecated in favor of",
"result.messages.dependency; postcss-loader >= v1.0.0 will",
"automatically add your imported files to webpack's file watcher.",
"For more information, see",
"https://github.com/postcss/postcss-import\
#dependency-message-support",
].join("\n"))
Object.keys(state.importedFiles)
.forEach(options.addDependencyTo.addDependency)
}
Expand Down
28 changes: 0 additions & 28 deletions test/import-events.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,34 +25,6 @@ test("should have a callback that returns an object" +
})
})

test("should have a callback shortcut for webpack", t => {
var files = []
var webpackMock = {
addDependency: file => {
files.push(file)
},
}

return postcss()
.use(atImport({
path: "fixtures/imports",
addDependencyTo: webpackMock,
}))
.process(readFileSync("fixtures/media-import.css"), {
from: "fixtures/media-import.css",
})
.then(() => {
t.deepEqual(
files,
[
resolve("fixtures/media-import.css"),
resolve("fixtures/imports/media-import-level-2.css"),
resolve("fixtures/imports/media-import-level-3.css"),
]
)
})
})

test("should add dependency message for each import", t => {
return postcss()
.use(atImport({
Expand Down

0 comments on commit dfe4c23

Please sign in to comment.