-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code style #32
Comments
Currently you do not use this preset and you eslint config don't enforce anything. You just parse with babel parser. |
Yeah, I know. :) If nobody voices an objection to /cc @ai @marcustisater what do you think, you fine with |
If you want to change, most rules can be automatically fix themselves (see eslint --fix option). So no big deal ;) |
|
Closes #32, we now use eslint-config-i-am-meticulous for the code style. This enforces a common style across all JS code.
Closes #32, we now use eslint-config-i-am-meticulous for the code style. This enforces a common style across all JS code.
Closes #32, we now use eslint-config-i-am-meticulous for the code style. This enforces a common style across all JS code.
Closes #32, we now use eslint-config-i-am-meticulous for the code style. This enforces a common style across all JS code.
Currently, the entire code follows @MoOx' eslint-config-i-am-meticulous.
To be honest, I don't think it matters which exact style guide we adhere to, as long as we choose one and force eslint to complete successfully before we merge anything into master.
I'd be fine with simply enforcing
eslint-config-i-am-meticulous
since the whole codebase is written like that at the moment and it'll save us time because we don't have to rewrite everything in a new style. Any objections?The text was updated successfully, but these errors were encountered: