Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style #32

Closed
mxstbr opened this issue Jan 7, 2016 · 4 comments
Closed

Code style #32

mxstbr opened this issue Jan 7, 2016 · 4 comments

Comments

@mxstbr
Copy link
Member

mxstbr commented Jan 7, 2016

Currently, the entire code follows @MoOx' eslint-config-i-am-meticulous.

To be honest, I don't think it matters which exact style guide we adhere to, as long as we choose one and force eslint to complete successfully before we merge anything into master.

I'd be fine with simply enforcing eslint-config-i-am-meticulous since the whole codebase is written like that at the moment and it'll save us time because we don't have to rewrite everything in a new style. Any objections?

Note: I personally am a big fan of eslint-config-airbnb with three custom rules, for an example of React code with that eslint config take a look at this example file.

@MoOx
Copy link
Contributor

MoOx commented Jan 7, 2016

Currently you do not use this preset and you eslint config don't enforce anything. You just parse with babel parser.
To use my preset, you will need to use this config http://moox.io/statinamic/docs/advanced/good-practises/#linting

@mxstbr
Copy link
Member Author

mxstbr commented Jan 7, 2016

Yeah, I know. :)

If nobody voices an objection to eslint-config-i-am-meticulous within 24 hours, I'll simply use that. I think it's the best solution, as it saves time which we don't have to spend to change the entire code style.

/cc @ai @marcustisater what do you think, you fine with eslint-config-i-am-meticulous?

@MoOx
Copy link
Contributor

MoOx commented Jan 7, 2016

If you want to change, most rules can be automatically fix themselves (see eslint --fix option). So no big deal ;)

@marcustisater
Copy link
Member

eslint-config-i-am-meticulous sounds good to me 👍

@marcustisater marcustisater added this to the Pre-1.0 milestone Jan 9, 2016
mxstbr added a commit that referenced this issue Jan 9, 2016
Closes #32, we now use eslint-config-i-am-meticulous for the code style.
This enforces a common style across all JS code.
@mxstbr mxstbr mentioned this issue Jan 9, 2016
mxstbr added a commit that referenced this issue Jan 9, 2016
Closes #32, we now use eslint-config-i-am-meticulous for the code style.
This enforces a common style across all JS code.
mxstbr added a commit that referenced this issue Jan 9, 2016
Closes #32, we now use eslint-config-i-am-meticulous for the code style.
This enforces a common style across all JS code.
mxstbr added a commit that referenced this issue Jan 9, 2016
Closes #32, we now use eslint-config-i-am-meticulous for the code style.
This enforces a common style across all JS code.
MoOx added a commit that referenced this issue Jan 9, 2016
@MoOx MoOx closed this as completed in aee030c Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants