-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository for OSD #96
Comments
I think it might be confusing to have separate repos for basically the same thing. I vote for |
My vote is for a separate repo for the design using this boilerplate for open design https://github.com/stephenway/open-design-boilerplate It is nice because you can diff each commit visually and designers can easily fork and iterate off it. So the main design repo would be mainly just the master layouts and guidelines for design practices. As we get new layouts defined, they can be added as PRs. |
@stephenway I think PRs and designs diff are also possible within one repo. Or am I missing something? |
That's what I'm scared of, right. If we have everything in this repository it can become very bloated and difficult to find the final cuts otherwise we can end up creating a very depth root of directories and files However.... I think we are also adding a extra step to this process by creating another repository. Is it worth it? That's my main concern. |
I think you're overcomplicating matters. We'll never be able to have mockups in sync with the website and I personally think we should not even try. As soon as the design concept is approved I'd move to the HTML/CSS/JS phase and would work from there. |
@okonet What makes you think the mockups will never be in sync? The idea is that we make this a project for working with others. Your comments seem to only address your personal concerns with this workflow. @marcustisater I think the long term benefits outweigh the needs of the few and that this will allow us to work faster as a team. Keeping the repo simple and focused will help guide the designer without extra cruft of the fronted code and documentation. |
Speaking from my experience. And I also think web-designers should write code. Once website is ready, the design will not be changed a lot (until a complete redesign) so I don't quite follow the effort to organize it so much. We'll end up with probably a few sketch files for design and lots of frontend code. But I might be missing something here. Could somebody explain me how you see the process? Either way I'm totally fine with both solutions (one repo and 2 repos). Just think the overhead isn't worth it. |
Completely agree. People will make PR to update the website and the sketch files will likely be outof date really quickly. |
I agree with @MoOx. We should start from CSS. Anyway right now all designers known CSS. It is a simplier and faster right now. In future we could find better way if wwe really will have non-CSS designers (but why they will contribute to CSS tool? ;) ). |
I am still stuck in between the middle after reading you're guys thoughts but I am going to make the final call and say that we will keep everything within this repository otherwise we will just keeping arguing back and forward. With that being said, @stephenway you might have to rethink you're strategy of how you want to organize OSD in this repository , talk over gitter and maybe @okonet can join us if you would be interested in helping with that too? reopend #27 |
Thanks for everyones quick input btw. I think the majority would either way lean towards option number duo. |
We had a discussion creating a new repository for the design part for postcss.org. I don't want to make the "final call" before we have discussed it.
The way I see it
Suggestions:
postcssorg-open-design
design
in this repository with assets.I would like to make this decisions very quick and straight forward. Thoughts?
OSD = Open Source Design
The text was updated successfully, but these errors were encountered: