Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository for OSD #96

Closed
marcustisater opened this issue Jan 20, 2016 · 11 comments
Closed

Repository for OSD #96

marcustisater opened this issue Jan 20, 2016 · 11 comments

Comments

@marcustisater
Copy link
Member

We had a discussion creating a new repository for the design part for postcss.org. I don't want to make the "final call" before we have discussed it.

The goals of this new repo would be to make a boilerplate for other designers to fork and design off of per page layout. So if we were to use this repo for that purpose, we would end up with 20+ sketch files alongside the website itself. I think approach could hurt the open nature of OSD, mainly because you should be able to fork quickly and iterate without any extra cruft. This might fall in line with your idea to do smaller PRs since we can selectively decide which forks are addressed in the org repo.

The way I see it

  • + Easier maintenance and for new contributors to get started.
  • - Confusing between repo collaborations.
  • -/+ We split one big repo into two parts

Suggestions:

  1. Create a new repository named ex. postcssorg-open-design
  2. Create a new directory design in this repository with assets.

I would like to make this decisions very quick and straight forward. Thoughts?

OSD = Open Source Design

@marcustisater marcustisater added this to the Pre-1.0 milestone Jan 20, 2016
@marcustisater marcustisater mentioned this issue Jan 20, 2016
@okonet
Copy link
Collaborator

okonet commented Jan 20, 2016

I think it might be confusing to have separate repos for basically the same thing. I vote for design directory.

@stephenway
Copy link
Collaborator

My vote is for a separate repo for the design using this boilerplate for open design https://github.com/stephenway/open-design-boilerplate

It is nice because you can diff each commit visually and designers can easily fork and iterate off it. So the main design repo would be mainly just the master layouts and guidelines for design practices. As we get new layouts defined, they can be added as PRs.

@okonet
Copy link
Collaborator

okonet commented Jan 20, 2016

@stephenway I think PRs and designs diff are also possible within one repo. Or am I missing something?

@marcustisater
Copy link
Member Author

That's what I'm scared of, right. If we have everything in this repository it can become very bloated and difficult to find the final cuts otherwise we can end up creating a very depth root of directories and files /design/src/layout/final/... also files that are not relevant. This repository should be somewhat "production/live" excluding files that are not relevant to the final deployment feels somewhat unorganized.

However.... I think we are also adding a extra step to this process by creating another repository. Is it worth it? That's my main concern.

@okonet
Copy link
Collaborator

okonet commented Jan 20, 2016

I think you're overcomplicating matters. We'll never be able to have mockups in sync with the website and I personally think we should not even try. As soon as the design concept is approved I'd move to the HTML/CSS/JS phase and would work from there.

@stephenway
Copy link
Collaborator

@okonet What makes you think the mockups will never be in sync?

The idea is that we make this a project for working with others. Your comments seem to only address your personal concerns with this workflow.

@marcustisater I think the long term benefits outweigh the needs of the few and that this will allow us to work faster as a team. Keeping the repo simple and focused will help guide the designer without extra cruft of the fronted code and documentation.

@okonet
Copy link
Collaborator

okonet commented Jan 20, 2016

What makes you think the mockups will never be in sync?

Speaking from my experience. And I also think web-designers should write code.

Once website is ready, the design will not be changed a lot (until a complete redesign) so I don't quite follow the effort to organize it so much. We'll end up with probably a few sketch files for design and lots of frontend code.

But I might be missing something here. Could somebody explain me how you see the process? Either way I'm totally fine with both solutions (one repo and 2 repos). Just think the overhead isn't worth it.

@MoOx
Copy link
Contributor

MoOx commented Jan 20, 2016

Once website is ready, the design will not be changed a lot (until a complete redesign) so I don't quite follow the effort to organize it so much.

Completely agree. People will make PR to update the website and the sketch files will likely be outof date really quickly.
I think it's a waste of time. We are mostly here CSS dev, so what about starting from a blank page and iterate on the code directly with PR accompagnied with screenshots (after a minimal start, but PNG/JPG I saw seems fine).

@ai
Copy link
Member

ai commented Jan 20, 2016

People will make PR to update the website and the sketch files will likely be outof date really quickly.

I agree with @MoOx. We should start from CSS. Anyway right now all designers known CSS. It is a simplier and faster right now. In future we could find better way if wwe really will have non-CSS designers (but why they will contribute to CSS tool? ;) ).

@marcustisater
Copy link
Member Author

I am still stuck in between the middle after reading you're guys thoughts but I am going to make the final call and say that we will keep everything within this repository otherwise we will just keeping arguing back and forward.

With that being said, @stephenway you might have to rethink you're strategy of how you want to organize OSD in this repository , talk over gitter and maybe @okonet can join us if you would be interested in helping with that too?

reopend #27

@marcustisater
Copy link
Member Author

Thanks for everyones quick input btw. I think the majority would either way lean towards option number duo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants