New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postcss-preset-env instead of cssnext #239 #240
Conversation
@ur300 it is always better to mention main maintainer in New pull request /cc @marcustisater |
Thanks for PR @ur300 👍Remember to reference the issue next time. Let me look through code and copy. |
Whops sorry my fault @ur300. You did reference it in the title 😄 Code looks good but I think the SVG should have a set height and width with correct viewbox like https://github.com/postcss/postcss.org/blob/master/web_modules/InANutshell/css-modules.svg has. Would you mind fixing that? That would be awesome! On the other hand I think the order should be like before, so
@ai @jonathantneal is the copy ok? See attacthed screenshot. |
web_modules/InANutshell/index.css
Outdated
@@ -7,6 +7,7 @@ | |||
|
|||
.logo { | |||
margin-right: 1rem; | |||
max-width: 80px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this. Set width and height through SVG.
Yeap. Let's more Preset Env to second position. And let's remove |
web_modules/InANutshell/index.css
Outdated
@@ -127,11 +128,12 @@ | |||
|
|||
.infoAlt { | |||
composes: info; | |||
margin-left: 1.5rem; | |||
margin-left: 0.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks a bit too tight.
This all seems good to me. |
hi @marcustisater, thanks for review. all the fixes are done - svg size, margin, order of features, media query name. |
@ur300 task is marked as solved by you https://cultofmartians.com/tasks/postcss-preset-env-postcss.html |
@ai, sweet, is this being merged today? |
We waiting for @marcustisater review and deploy |
SVG viewbox is still odd, but I can fix it later. LGTM |
@ai @jonathantneal bah, something is wrong with deploy 😢 I think it has something to do with the node env or when we switched over to HTTPS. Let me check tonight. Sorry for troubles! I will let you know when it's fixed. |
@ai @jonathantneal I deployed from local env, should be up live now 😄 I will add new issue for auto deploy trouble. 😓 |
postcss-preset-env added to the main page instead of cssnext