exclude nodes which are not schedulable from neighbour checks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghouscht
changed the title
ghouscht
force-pushed
the
feat/discovery
branch
from
1b2f454
to
b6acb93
Compare
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubenurse currently checks all othe kubenurse instances and reports metrics about the reachability of those neighbours. Due to the fact, that kubenurse runs as a Daemonset, it is not possible to evict pods.
Assume an operator performs a disruptive maintenance task on a node and thus disables scheduling on that node. The kubenurse pod of the affected node continues to run an may report errors depending on the task performed. This PR excludes neighbour Pods on nodes which are disabled and thus helps to improve this situation. A follow-up is required to disable other checks on nodes which are disabled.
related to #13