Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#220): skip <script> and <style> with SRI #221

Merged
merged 4 commits into from
Jan 8, 2023

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jan 8, 2023

The PR fixes #220.

The PR makes htmlnano skip any <script /> and <style /> tags that have SRI attributes, including minifyJs, minifyCss, minifyJson, mergeStyles and mergeScripts.
The reason behind the change is documented in the comment, and test cases about the change are also added.

@SukkaW SukkaW changed the title fix(#220): should not minify <script> and <style> with SRI fix(#220): skip <script> and <style> with SRI Jan 8, 2023
Copy link
Member

@maltsev maltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maltsev maltsev merged commit 688cf37 into posthtml:master Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content security policy hashes problem
2 participants