The correct way to add icons #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This custom widget is inspired by the search boxes in applications like gedit or Firefox. It should work as a replacement of a combo box + a spinner button used in GTK2 which does not look so great in GTK3.
List of books, chapters in a book, and verses in a chapter implemented with the new custom widget. May need some polishing in future but works sufficiently good for now.
The CSS file is empty for now. The aim of this commit is to separate the infrastructure (loading the CSS file) from the specific application.
Define some CSS classes and assign them to some widgets of the floating window. Define their style in the CSS file. Define another class "focused" and its style. Assign the "focused" class to the only one focused floating window. This is a port of commit 503b2b4 to GTK3 with CSS.
Recent works on the close buttons in floating windows and their tabs ported to the up-to-date features of GTK3. Some deprecated features (e.g., stock icons) removed, replaced with the CSS styling.
This is required because of the macros used in combo_with_arrows.
Based on the old icons, edited for new sizes.
It is not yet deleted but may be in future. The new icon added in the previous commit is used instead.
This includes the *.desktop file rename and corrections.
Closes postiffm#115
MAP added 8/24/2019: Resolve small conflict introduced by PR postiffm#124
The application menu is visible in some desktop environments (e.g., some versions of GNOME). Other systems must use the traditional menu bar which is not changed.
Factor out some common code into webview_simple.h/cpp windowreferences.cpp compiles windowcheckkeyterms.cpp compiles Work on windownotes.cpp, but problems (cut/copy/paste) windowshowrelatedverses.cpp compiles displayprojectnotes.cpp compiles Remove get_reference from WindowCheckKeyterms; use constructor instead General code cleanup rluzynski and postiffm squashed a later commit into this commit in order to undo some changes in src/webkitbrowser.h that were not ideal. This commit was purely technical. Its aim is to undo some changes made in one of the previous commits only in order to redo them in a more correct way.
webkit_web_view_open has been deprecated since version 1.1.1 and should not be used in newly-written code. Use webkit_web_view_load_uri() instead.
The signals "load-committed", "load-started", and "load-finished" are now replaced by a single signal "load-changed". The signal "load-progress-changed" must be replaced by "notify::estimated-load-progress".
In GTK3 we had some warnings saying "GtkDialog mapped without a transient parent." In fact, we have never needed this window to be a modal dialog box. From now it is a regular GtkWindow. Remove SystemlogDialog::on_system_log_close() Due to the previous commit this method not only does nothing but also there is no way to use it ever in the future.
The changes readd assigments that will install the xpm icon into the pixmaps folder. This fixes no icon appearing for the menu item.
|
@rluzynski Sorry for the delay in looking at this. I am extremely busy right now, so this might sit for a while. I think I am understanding what you want to do with this. |
Prior to this change the following warning was added to the log file: "Your application claims to support custom command line handling but does not implement g_application_command_line() and has no handlers connected to the 'command-line' signal."
This is the correct way to add an icon to GTK3 application.
This reverts commit 4f9f304.
|
I lost track of this very badly. Sorry. Is it still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this pull request literally. Since the
gtk3branch is a development branch and rewriting history is allowed, my suggestion is:Fixup for "New icons."should be squashed into the older commitNew icons.This should make some unnecessary files just disappear without any trace instead of being created by one commit and then deleted by another one.Revert "Update makefile for pixmap"could be squashed into the originalUpdate makefile for pixmapbut this would make the commit disappear. Instead of this it is OK to just drop both the original commit and the revert.This fixup is inspired by the article http://ptomato.name/advanced-gtk-techniques/html/desktop-file.html.