-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-raise TimeoutError when pairing #2242
Comments
postlund
added a commit
that referenced
this issue
Oct 16, 2023
Use error_handler when connecting to pass-through a few exceptions, to enaure they are not hidden behind an AuthenticationError. This helps a lot in Home Assistant currently. Relates to #2242
postlund
added a commit
that referenced
this issue
Oct 16, 2023
Use error_handler when connecting to pass-through a few exceptions, to enaure they are not hidden behind an AuthenticationError. This helps a lot in Home Assistant currently. Relates to #2242
postlund
added a commit
that referenced
this issue
Oct 16, 2023
Use error_handler when connecting to pass-through a few exceptions, to enaure they are not hidden behind an AuthenticationError. This helps a lot in Home Assistant currently. Relates to #2242
Fixed in #2246. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What to change?
Currently pyatv tries to be "smart" by catching more or less all exceptions that happens during pairing and connecting and just re-raises them as an
AuthenticationError
. In like 99% of the cases, that works just fine. Sometimes however a timeout occurs (for whatever reason), which is re-raised asAuthenticationError
. IMHO, that exception should just be kept as is as it's not really a problem with the authentication.Main reason for changing this is this case in Home Assistant:
When an
AuthenticationError
is raised, the Apple TV integration will trigger a reconfiguration which is very annoying. Sometimes the connection will fail, but trying again will restore function again. So changing this would help a lot I think.The text was updated successfully, but these errors were encountered: