Fix CSV Auto Parse #1609
Merged
Fix CSV Auto Parse #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use new `cast` method - Add Custom method to Auto Parse values - Use casting context to avoid parsing values surrounded with quotes
…to feature/csv-parse
kunagpal
suggested changes
Jul 2, 2018
| * @returns {String|Number|Date} | ||
| */ | ||
| csvAutoParse = function (value, context) { | ||
| if (context.quoting) { |
There was a problem hiding this comment.
Make the if blocks consistent by returning the processed value directly, this will also let you remove else all over.
| * @param {String} value - CSV field value | ||
| * @param {Object} context - Context of field value | ||
| * @param {Boolean} context.quoting - A boolean indicating if the field was surrounded by quotes. | ||
| * @returns {String|Number|Date} |
| * @param {String} value - The string to test for. | ||
| * @returns {Boolean} | ||
| */ | ||
| isInt: function (value) { |
There was a problem hiding this comment.
Were these taken from csv-parse? If so, add a comment linking to the original code in this, as well as the function below.
There was a problem hiding this comment.
Yes, added the reference in the below function. Will add a proper description.
kunagpal
approved these changes
Jul 3, 2018
shamasis
requested changes
Jul 13, 2018
| @@ -16,9 +16,11 @@ | |||
| "type": "text/javascript", | |||
| "exec": [ | |||
| "var res = JSON.parse(responseBody);", | |||
| "tests['Stringified number was parsed correctly'] = data.num === 1;", | |||
There was a problem hiding this comment.
this test was removed @codenirvana ?
There was a problem hiding this comment.
@shamasis It was replaced with an equivalent, as can be seen in the CSV fixture below.
shamasis
approved these changes
Jul 13, 2018
This was referenced Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1100 #1215 #1346
csv-parsecasting context to avoid parsing values surrounded by quotes