Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsdoc documentation for functions #183

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Jsdoc documentation for functions #183

wants to merge 2 commits into from

Conversation

vibhorgupta-gh
Copy link

@vibhorgupta-gh vibhorgupta-gh commented Mar 16, 2020 •
edited
Loading

fixes #166

@umeshp7 @shreys7 please review. Documented to the best of my understanding, though I still feel like a better job can be done for some params after some discussion.

ProBeta1
ProBeta1 reviewed Mar 18, 2020
View reviewed changes
Copy link

@ProBeta1 ProBeta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there , for each function , you also need to add one-liner describing what it is supposed to do :)

@umeshp7
Copy link
Contributor

umeshp7 commented Jun 12, 2020

@VibhorCodecianGupta
Could you please resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProBeta1 ProBeta1 ProBeta1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JS Docs for all the functions
3 participants
@vibhorgupta-gh @umeshp7 @ProBeta1