Fixed issue where generated collection contained request and folder in incorrect order. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While introduction of v2 interface, we introduced
graphliband use of Tree graph and preorder traversal to better organize collection folders and requests. This implementation did not add support for the folder/request creation in same order as mentioned in definition and order was reverse-alphbetical.RCA
V2 implementation relied on certain criteria that before each request creation, the folder corresponding to it should already be created as nodes. Due to this we used to reverse sort the path and then create the Tree graph. this created the problem of incorrect order in generated collection
Fix
With this PR, we're adding support for this Tree graph creation to be in same order as mentioned in definition/ This results in also generated collection being in order as Preorder traversal of this Tree graph generates request/folder in same order as defined in definition.