Reduced collection size by keeping maximum generated elements for array as 1 for larger schemas. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for restricting the elements generated in collection from default 2 to 1 element based upon the schema size. Current threshold for this is for schemas larger than 50 KB.
Solution
We've removed the part where
minItemsandmaxItemswere had coded into schema while resolution and added support for this injson-schema-fakerlibrary. In jsf library we've added similar logic by usage of options that can be configured while using this library. And while faking the schema, we use these options depending upon the schema size.