Adds inherited auth test cases #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryi3t
force-pushed
the
feature/inherited-auth-tests
branch
from
f4c3618
to
a3fb075
Compare
kunagpal
suggested changes
Oct 17, 2017
|
|
||
| expect(err).to.be(null); | ||
| expect(request.url.toString()).to.eql('https://postman-echo.com/basic-auth'); | ||
| expect(response.code).to.eql(200); |
|
|
||
| describe('in collection and request level', function () { | ||
| before(function (done) { | ||
| var clonedRunOptions = _.merge({}, runOptions, |
There was a problem hiding this comment.
Remove the first argument to _.merge, and shift runOptions to after the collection.
There was a problem hiding this comment.
@kunagpal we want the options to override runOptions always, but not mutate it. _.defaults does not do a deep merge.
harryi3t
added a commit
that referenced
this pull request
Oct 17, 2017
kunagpal
previously approved these changes
Oct 17, 2017
harryi3t
force-pushed
the
feature/inherited-auth-tests
branch
from
1014b8f
to
94a8120
Compare
harryi3t
added a commit
that referenced
this pull request
Oct 17, 2017
harryi3t
force-pushed
the
feature/inherited-auth-tests
branch
from
dd07dea
to
59cbc64
Compare
kamalaknn
approved these changes
Oct 17, 2017
kunagpal
added a commit
that referenced
this pull request
Nov 2, 2017
* release/6.4.2: (22 commits) Released v6.4.2 Disable localhost IPv6 test on Travis Fix syntax errors Syntax changes Code styling fixes Allow IP address/host restrictions using `restrictedAddresses` option Make sure `request` command does not crash for unhandled errors in `http-request` command chore(package): update eslint to version 4.10.0 chore(package): update sinon to version 4.0.2 chore(package): update ajv to version 5.3.0 chore(package): update ajv to version 5.2.5 chore(package): update editorconfig to version 0.15.0 chore(package): update eslint-plugin-lodash to version 2.5.0 Add tests for test scripts in inherited events Point to postman-collection develop for order preserving in events Make sure order is preceived in events Added tests for inherited events Remove the `suppressEventPropagation` for inherited events Fixes as per review comments #422 Adds test case for request level auth overriding collection level auth ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.