Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's play with embeds #32

Open
Vernal opened this issue Jul 31, 2015 · 2 comments
Open

Let's play with embeds #32

Vernal opened this issue Jul 31, 2015 · 2 comments

Comments

@Vernal
Copy link
Contributor

Vernal commented Jul 31, 2015

https://github.com/dereuromark/MediaEmbed might be a good place to start to provide support for media embeds in comments.

@Vernal Vernal added this to the 1.1 milestone Aug 13, 2015
@ronalfy
Copy link
Contributor

ronalfy commented Aug 18, 2015

Maybe just use the filters WordPress is using for Embeds?

$vidembed = new WP_Embed();
add_filter( 'comment_text', array( &$vidembed, 'run_shortcode'), 8 );
add_filter( 'comment_text', array( &$vidembed, 'autoembed'), 8 );
add_filter( 'comment_text', 'do_shortcode', 11);

Untested, but theoretically can do oembed and shortcodes.

@Vernal
Copy link
Contributor Author

Vernal commented Aug 18, 2015

Perhaps.. that might be a good place to start. The drawback is that the list of providers is short and the primary use would most certainly be images. That leaves just flickr and imgur. With MediaEmbed or oembed-all we could support something as generic as a link to a image hosted anywhere on the web. It would open up a lot of possibilities.

But yes. For 1.1, maybe using the native embed filters would do nicely. Or maybe the native embed filters and we add some sort of generic oEmbed provider for images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants