Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more addjob options #15

Closed
felixbuenemann opened this issue Aug 9, 2015 · 2 comments
Closed

Expose more addjob options #15

felixbuenemann opened this issue Aug 9, 2015 · 2 comments

Comments

@felixbuenemann
Copy link
Contributor

Disque supports multiple parameters to control job execution:

ADDJOB queue_name job <ms-timeout>
  [REPLICATE <count>]
  [DELAY <sec>]
  [RETRY <sec>]
  [TTL <sec>]
  [MAXLEN <count>]
  [ASYNC]

It seems currently only delay is exposed in disc. Shouldn't it be possible to set the other options on the job class and when enqueing? The retry time strikes me as particularly important, because it depends on the average execution time of each job.
@foca
Copy link
Collaborator

foca commented Aug 9, 2015

👍

Given that disque-rb already allows this, it should be pretty easy to implement. Care to send a PR? ❤️

@felixbuenemann
Copy link
Contributor Author

I'm not yet using disc anywhere, but I'll give it a shot.

felixbuenemann added a commit to felixbuenemann/disc that referenced this issue Aug 9, 2015
@felixbuenemann
Add support for passing job options to disque
06fd1f5 
This allows to pass arbitrary options to disque-rb and resolves pote#15.
Also moved the default queue to an accessor on Disc, so it can be
configured globally via Disc.default_queue = "foo".
@felixbuenemann felixbuenemann mentioned this issue Aug 9, 2015
Merged
@pote pote closed this as completed in 2c96e12 Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foca @felixbuenemann