This repository has been archived by the owner on Nov 9, 2021. It is now read-only.
Adding support for changing dynamic segments. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks! This is failing because
|
| @@ -35,8 +35,9 @@ export default Component.extend({ | |||
| classNameBindings: [ 'breadCrumbClass' ], | |||
| hasBlock: computed.bool('template').readOnly(), | |||
| currentRouteName: computed.readOnly('applicationController.currentRouteName'), | |||
|
Thanks! I'll update this and address your notes tonight. |
gmurphey
force-pushed
the
dynamic-segments
branch
2 times, most recently
from
13b24a8
to
f902b7d
Compare
|
|
gmurphey
force-pushed
the
dynamic-segments
branch
from
f902b7d
to
adc773c
Compare
|
Hold off on the rebase, I'm updating ember-cli |
| get() { | ||
| const currentRouteName = getWithDefault(this, 'currentRouteName', false); | ||
| const currentRouteName = getWithDefault(this, 'applicationRoute.controller.currentRouteName', false); |
There was a problem hiding this comment.
Can we create a computed property for the currentRouteName, much like the one on L31?
gmurphey
force-pushed
the
dynamic-segments
branch
from
adc773c
to
447d3ef
Compare
|
This is rebased with the improvements you noted. Thanks! |
|
👍 Thanks @gmurphey! Sorry for dropping the ball on this. |
poteto
added a commit
that referenced
this pull request
Aug 15, 2015
Adding support for changing dynamic segments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you change a dynamic segment in a URL the
applicationController.currentRouteNameremains the same (e.g., if a URL changes from/users/potetoto/users/gmurphey, thecurrentRouteNameremainsusers.user).Unfortunately, the
ApplicationControlleronly has access tocurrentRouteNameandcurrentPath; neither of which is aware of dynamic segments. The easiest way to get around this was to injectroute:applicationintocomponent:bread-crumbs, where you can accessapplicationRoute.router.url, and base crumb computation off changes to theurl.