Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track multi-line function calls #33

Closed
adriandmitroca opened this issue Jul 29, 2016 · 3 comments
Closed

Track multi-line function calls #33

adriandmitroca opened this issue Jul 29, 2016 · 3 comments
Milestone

Comments

@adriandmitroca
Copy link
Contributor

adriandmitroca commented Jul 29, 2016

Hey,

I found that this package has some serious issue when you call trans() function like this:

trans('user.welcome', [
    'name' => $user->name
]);

Situation like this is tracked like obsolete string or is not tracked at all. It works just fine when parameters are passed in the same line.

@potsky
Copy link
Owner

potsky commented Jul 29, 2016

Hi,

I will check this in September but I think that default regex do not support multiline trans. You can modify this behavior in your configuration file by setting a correct regex modifier to match multi lines.

In your example, the closing ) is missing. Is this not the problem ?

@adriandmitroca
Copy link
Contributor Author

adriandmitroca commented Jul 29, 2016

Hey,

Thanks for your answer. Missing ) is just typo in example. I will try to look into this regex.

Max13 added a commit to Max13/laravel-localization-helpers that referenced this issue Aug 21, 2016
Max13 added a commit to Max13/laravel-localization-helpers that referenced this issue Aug 21, 2016
Max13 added a commit to Max13/laravel-localization-helpers that referenced this issue Aug 21, 2016
- See issue potsky#33
- Added tests
@potsky
Copy link
Owner

potsky commented Sep 27, 2016

Will be fixed in the next release.

@potsky potsky closed this as completed Sep 27, 2016
@potsky potsky modified the milestone: 2.x.4 Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants