Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

61 setup simple auth0 authentification #82

Merged
merged 18 commits into from
Nov 4, 2019
Merged

61 setup simple auth0 authentification #82

merged 18 commits into from
Nov 4, 2019

Conversation

deonclem
Copy link
Collaborator

@deonclem deonclem commented Oct 26, 2019 •
edited
Loading

Go to /auth/login to access the login form. You should be able to log out from a profile once logged in.

image

image

I still need to investigate why it shows the auth0 domain on the Google login form:

image

The Auth0 application: https://manage.auth0.com/dashboard/eu/dev-cajmwjmi/

The Google OAuth app: https://console.developers.google.com/apis/dashboard?project=tottem

You should have access to both.

It should work fine on production (tottem.app domain) but I have no idea how it will behave / how to properly support dynamic subdomains from the Now deployments. The easiest way to test for now is locally.

cdeon added 13 commits October 13, 2019 18:13
#61 Add basic auth with Auth0 with callback redirection and empty sec…
a0a7da7 
…ure_page
#61 Remove auth0 variables from repo
1cadf73
#61 Git ignore auth0-variables file
b528be2
#61 Display name and logout link in header + remove sign in button an…
2e83709 
…d secure_page
#61 Make Auth0 methods globally available and improve UI
b4e112f
#61 Fallback to nickname if no given_name
48fdadc
#61 Correctly clear session on Auth0 when logging out
843ce97
#61 Readd auth0 variables file
0729fb4
Merge branch 'master' into 61-setup-simple-auth0-authentification
3fbd12e 
# Conflicts:
#	.gitignore
#61 Correctly handles local and prod domains
e54919b
Merge branch 'master' into 61-setup-simple-auth0-authentification
08075ce 
# Conflicts:
#	package.json
#	src/components/Views/Header.tsx
#	src/pages/index.tsx
#61 Fix header info
bff24bd
#61 Improve integration of Logout button in header
587626f
@vercel
Copy link

vercel bot commented Oct 26, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/quiet/quiet/mqsvj6dyd
🌍 Preview: https://quiet-git-61-setup-simple-auth0-authentification.quiet.now.sh

@deonclem
Copy link
Collaborator Author

deonclem commented Oct 26, 2019 •
edited
Loading

Also, clearly not a fan of how the redirections are handled right now but I guess it will be better when we have a proper login button.

poulainv
poulainv reviewed Oct 28, 2019
View reviewed changes
src/components/Views/Header.tsx Outdated Show resolved Hide resolved
src/lib/auth0-variables.js Outdated Show resolved Hide resolved
@poulainv
Copy link
Owner

What are you worried about dynamic domain? I don't understand everything but we could merge as it does not impact user experience for now. Maybe we should plan a call while we could read all of this together!

@poulainv
Copy link
Owner

Sorry for conflict :/

cdeon added 2 commits October 31, 2019 20:22
Merge branch 'master' into 61-setup-simple-auth0-authentification
85187d0 
# Conflicts:
#	next.config.js
#	src/components/Views/Header.tsx
#	src/pages/index.tsx
#61 Use StyledButton for Logout button
e1b16f6
@vercel vercel bot had a problem deploying to staging November 1, 2019 12:41 Failure
@deonclem
Copy link
Collaborator Author

deonclem commented Nov 4, 2019

What are you worried about dynamic domain? I don't understand everything but we could merge as it does not impact user experience for now. Maybe we should plan a call while we could read all of this together!

Similar problem explained here: https://spectrum.chat/zeit/now/now-secrets-and-login-url-redirection~4bc64b46-5052-4ac2-9742-636b34be743f

Right now on https://quiet-cxckges17.now.sh you will get redirect on tottem.app after login (so it doesn't work). There must be a way to dynamically get the deployed domain in the code but I'm not sure how to make Auth0 support it (as I don't think you can use wildcards as authorized domains - i.e. quiet-*.now.sh)

Happy to merge for now 🙂

Merge branch 'master' into 61-setup-simple-auth0-authentification
c6b6b7d 
# Conflicts:
#	src/components/Views/Header.tsx
@deonclem deonclem merged commit 9b9a14c into master Nov 4, 2019
@deonclem deonclem deleted the 61-setup-simple-auth0-authentification branch November 4, 2019 13:32
@deonclem deonclem mentioned this pull request Nov 4, 2019
Closed
deonclem pushed a commit that referenced this pull request Nov 5, 2019
#82 Improve Francois collection
c6c4995
deonclem pushed a commit that referenced this pull request Nov 6, 2019
#82 Fix book name and image
6c9bb7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulainv poulainv poulainv left review comments

Assignees

@poulainv poulainv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deonclem @poulainv