Multiple config changes in a single tooltip #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
On Thu, 16 Nov 2023, 18:15 Pierre GIRAUD, ***@***.***> wrote:
Fix for #165 (comment)
<#165 (comment)>
------------------------------
You can view, comment on, or merge this pull request online at:
#181
Commit Summary
- 9219f31
<9219f31>
Explicitely load Roboto font
Just a quick note on that commit. For now powa-web is entirely self
contained, in the sense that it won't open any external connection, except
of course the remote servers in some pages (which can entirely be opt out).
I think that a lot of people expect this behaviour and wouldn't be happy
with such a change. I think that at least pgadmin faced quite some backlash
recently with something similar for instance. Could you instead add the
underlying file(s) locally?
… Message ID: ***@***.***>
|
|
In your second commit, you can specify that only the first five changes are displayed. |
pirlgon
reviewed
Nov 16, 2023
pgiraud
force-pushed
the
multiple_config_changes
branch
from
0e429f2
to
06435cc
Compare
|
Here's the new styling which I hope is easier to read. |
pgiraud
force-pushed
the
multiple_config_changes
branch
from
06435cc
to
2804e1f
Compare
|
Rebased. |
rjuju
reviewed
Nov 21, 2023
Instead of hoping that this font is available on user's machine. This will allow us to use font emphasis variants from Vuetify.
In order to show a single tooltip for events occuring at the same date. Also, make the tooltip content more readable.
|
I force pushed new commits but I don't see them here. Last commit should be 8bb862f. |
pgiraud
force-pushed
the
multiple_config_changes
branch
from
2804e1f
to
8bb862f
Compare
rjuju
approved these changes
Nov 21, 2023
|
Thanks a lot! The latest commit is now visible on the UI so it should be ok to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #165 (comment)