Allow to pass custom API base url #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous lib version allowed to use custom url by using a config file, there was no easy way to use the lib to communicate with several hipchat instances from the same application. This solution allows to pass the base url as an optional param to the classes doing the communication
|
Thank you for your contribution! I have published version1.2 with this addition. |
|
thanks for the quick review and release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous lib version allowed to use custom url by using a
config file, there was no easy way to use the lib to communicate with
several hipchat instances from the same application.
This solution allows to pass the base url as an optional param to
the classes doing the communication
Close #22