refactor: Improve code quality

powerapi/processor/pre/k8s/k8s_monitor.py

@@ -29,10 +29,8 @@
 
 # pylint: disable=W0603,W0718
 
-import logging
-import multiprocessing
-from logging import Logger
-from multiprocessing import Process
+from logging import Formatter, getLogger, Logger, StreamHandler, WARNING
+from multiprocessing import Manager, Process
 
 from kubernetes import client, config, watch
 from kubernetes.client.configuration import Configuration
@@ -144,7 +142,7 @@ class K8sMonitorAgent(Process):
     when pod are created, removed or modified.
     """
 
-    def __init__(self, name: str, concerned_actor_state: K8sPreProcessorState, level_logger: int = logging.WARNING):
+    def __init__(self, name: str, concerned_actor_state: K8sPreProcessorState, level_logger: int = WARNING):
         """
         :param str name: The actor name
         :param K8sPreProcessorState concerned_actor_state: state of the actor that will use the monitored information
@@ -153,17 +151,17 @@ def __init__(self, name: str, concerned_actor_state: K8sPreProcessorState, level
         Process.__init__(self, name=name)
 
         #: (logging.Logger): Logger
-        self.logger = logging.getLogger(name)
+        self.logger = getLogger(name)
         self.logger.setLevel(level_logger)
-        formatter = logging.Formatter('%(asctime)s || %(levelname)s || ' + '%(process)d %(processName)s || %(message)s')
-        handler = logging.StreamHandler()
+        formatter = Formatter('%(asctime)s || %(levelname)s || ' + '%(process)d %(processName)s || %(message)s')
+        handler = StreamHandler()
         handler.setFormatter(formatter)
 
         # Concerned Actor state
         self.concerned_actor_state = concerned_actor_state
 
         # Multiprocessing Manager
-        self.manager = multiprocessing.Manager()
+        self.manager = Manager()
 
         # Shared cache
         self.concerned_actor_state.metadata_cache_manager = K8sMetadataCacheManager(process_manager=self.manager,

tests/unit/cli/test_generator.py

@@ -28,12 +28,11 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import os
-import re
-from re import Pattern
+from re import compile, Pattern
 
 import pytest
 
-from powerapi.cli.generator import PullerGenerator, DBActorGenerator, PusherGenerator, ProcessorGenerator, \
+from powerapi.cli.generator import PullerGenerator, DBActorGenerator, PusherGenerator, \
     MonitorGenerator, MONITOR_NAME_SUFFIX, LISTENER_ACTOR_KEY, PreProcessorGenerator
 from powerapi.cli.generator import ModelNameDoesNotExist
 from powerapi.processor.pre.k8s.k8s_monitor import K8sMonitorAgent
@@ -292,7 +291,7 @@ def test_generate_several_pushers_from_config(several_inputs_outputs_stream_conf
             assert db.metric_name == current_pusher_infos['metric_name']
 
         elif pusher_type == 'virtiofs':
-            assert db.vm_name_regexp == re.compile(current_pusher_infos['vm_name_regexp'])
+            assert db.vm_name_regexp == compile(current_pusher_infos['vm_name_regexp'])
             assert db.root_directory_name == current_pusher_infos['root_directory_name']
             assert db.vm_directory_name_prefix == current_pusher_infos['vm_directory_name_prefix']
             assert db.vm_directory_name_suffix == current_pusher_infos['vm_directory_name_suffix']

tests/unit/processor/pre/k8s/test_k8s_monitor.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2023, INRIA
 # Copyright (c) 2023, University of Lille
 # All rights reserved.
-from time import sleep
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
 
@@ -29,6 +28,7 @@
 
 # pylint: disable=R6301,W0613,W0221
 
+from time import sleep
 from unittest.mock import patch, Mock
 
 import pytest