[PLAY-53]Create partials for visual guideline card sections #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleschechter
added
docs
improvement
kyleschechter
added
the
milano
kre8sions
approved these changes
Jan 14, 2022
thestephenmarshall
approved these changes
Jan 17, 2022
thestephenmarshall
added a commit
that referenced
this pull request
Jan 26, 2022
* Created partials for visual guideline cards * Max width and number spacing refactored * Refactored w/ partials for line height, position, spacing * Finished refactor and cleaned up some syntax * Fixed a naming error for color backgrounds Co-authored-by: Stephen Marshall <stephen.marshall@powerhrg.com>
jasperfurniss
added a commit
that referenced
this pull request
Jan 26, 2022
* [PLAY-43] Add size prop to the button kit (#1714) * Added size prop to the button kit * Fixed specs * Updated tests and default size * React classname order upate to match with Rails * [PLAY-32] Global: Add display props to ALL kits (#1723) * Display props working on React and Rails * spacing fix * Update dependency flow-runtime to v0.17.0 (#1711) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency eslint-plugin-flowtype to v4.7.0 (#1710) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency copy-webpack-plugin to v6.4.1 (#1708) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency @types/react to v17.0.38 (#1701) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency es5-shim to v4.6.4 (#1700) Co-authored-by: Renovate Bot <bot@renovateapp.com> * [PLAY-53]Create partials for visual guideline card sections (#1718) * Created partials for visual guideline cards * Max width and number spacing refactored * Refactored w/ partials for line height, position, spacing * Finished refactor and cleaned up some syntax * Fixed a naming error for color backgrounds Co-authored-by: Stephen Marshall <stephen.marshall@powerhrg.com> * 10.18.0 * Add blue color option to PbIconCircle kit * 10.18.1 * Fix spec test for icon circle * fixed dark mode colors (#1732) * [PLAY-70]Nav Kit new "bold" variant (#1733) * Bold variant added, needs hover styling * Vertical bold variant working * Added hover effect and text more bold * Bold variant finished with doc examples * Added spec for bold variant * Adding lineHeight props examples and partial functionality (#1720) * Adding lineHeight props examples and partial functionality * Partial update to react props * Started adding more ruby references * Reverting test changes i committed * Finalizing react and rails code for functionality * Adding specs for line height * [Play-80] Updating padding prop to popover kit (#1727) * Updating padding prop to popover kit * Fixing padding to scroll and height settings * [PLAY-44]Bug Fix Text-input add-on error border color (#1712) * Bug fixed with add on border * Removed commented out css * Final tweaks * Removed important from selectors in scss file * [PLAY-51] allow base typography to have access to basic text colors (#1728) * reset dist files * Updated dist files * Added color prop in kits * Added rails specs * Added rails specs * Rails specs * Updated docs * Set default value in title kit * Added default nil to caption kit * Added colors to sass file * Added spec files for caption and title kit * Added JS specs * Merge conflicts * Added light color to caption * Took variant prop out of title kit * Fixed description doc for title props * body kit done * title kit done * Merge * Merge conflict * Lightbox (#1734) * Lightbox V1 * Fixing Yarn Lock * Removing Other Code * Removing Unnecessary Files * Fixing Broken Image Build * Latest * Getting rid of circular dep * Referenced Icon Kit Directly * Importing Image Kit Directly from Image Component * Updated Doc Example Props * Corrected Prop Name * Latest * [PLAY] Override add on padding for text input (#1739) * Override add on padding for text input * Fixed error border color * Remove dist folder tracking (#1742) * Revert "[PLAY-43] Add size prop to the button kit (#1714)" This reverts commit 52474d4. Co-authored-by: Jelena Durovic <82796889+JelenaD1@users.noreply.github.com> Co-authored-by: Nick Amantia <92755007+nickamantia@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Kyle Schechter <84349455+kyleschechter@users.noreply.github.com> Co-authored-by: Jonathan Gonzalez <84339183+jon1735@users.noreply.github.com> Co-authored-by: Rob Gentile <84338865+RobGentile17@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasperfurniss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
(Page has no visible changes)
Breaking Changes
No, this PR does change the name of the file
_pb_doc_shadow.html.erbto_shadows.html.erbbecause it fits the naming conventions of the directory better, but It is made backwards compatible.Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-53
How to test this
Compare the look of the visual guidelines in this PR to the look of
master. If they all still look the same, the refactor with partials works.Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.