Revert "[PLAY-43] Add size prop to the button kit" #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added size prop to the button kit * Fixed specs * Updated tests and default size * React classname order upate to match with Rails
* Display props working on React and Rails * spacing fix
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Created partials for visual guideline cards * Max width and number spacing refactored * Refactored w/ partials for line height, position, spacing * Finished refactor and cleaned up some syntax * Fixed a naming error for color backgrounds Co-authored-by: Stephen Marshall <stephen.marshall@powerhrg.com>
* Bold variant added, needs hover styling * Vertical bold variant working * Added hover effect and text more bold * Bold variant finished with doc examples * Added spec for bold variant
* Adding lineHeight props examples and partial functionality * Partial update to react props * Started adding more ruby references * Reverting test changes i committed * Finalizing react and rails code for functionality * Adding specs for line height
* Updating padding prop to popover kit * Fixing padding to scroll and height settings
* Bug fixed with add on border * Removed commented out css * Final tweaks * Removed important from selectors in scss file
…1728) * reset dist files * Updated dist files * Added color prop in kits * Added rails specs * Added rails specs * Rails specs * Updated docs * Set default value in title kit * Added default nil to caption kit * Added colors to sass file * Added spec files for caption and title kit * Added JS specs * Merge conflicts * Added light color to caption * Took variant prop out of title kit * Fixed description doc for title props * body kit done * title kit done * Merge * Merge conflict
* Lightbox V1 * Fixing Yarn Lock * Removing Other Code * Removing Unnecessary Files * Fixing Broken Image Build * Latest * Getting rid of circular dep * Referenced Icon Kit Directly * Importing Image Kit Directly from Image Component * Updated Doc Example Props * Corrected Prop Name * Latest
* Override add on padding for text input * Fixed error border color
This reverts commit 52474d4.
jasoncypret
approved these changes
Jan 26, 2022
thestephenmarshall
force-pushed
the
master
branch
from
4e80198
to
428cca4
Compare
thestephenmarshall
added a commit
that referenced
this pull request
Jan 26, 2022
This reverts commit 91eb894.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1714