Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subprojects #44

Merged
merged 10 commits into from
Jul 11, 2024
Merged

Add subprojects #44

merged 10 commits into from
Jul 11, 2024

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Jun 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Documentation update

What is the current behavior?
Only 3 subprojects are linked in the parent documentation page

What is the new behavior (if this is a feature change)?
Other projects are added to the list of subprojects.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:
Some links may not be fully functional yet.

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras changed the title Add subprojects [WIP] Add subprojects Jun 19, 2024
@So-Fras So-Fras self-assigned this Jun 20, 2024
@So-Fras So-Fras marked this pull request as ready for review June 20, 2024 09:03
@So-Fras So-Fras requested a review from annetill June 20, 2024 09:28
@So-Fras So-Fras changed the title [WIP] Add subprojects Add subprojects Jun 20, 2024
@@ -1,5 +1,17 @@
# PowSyBl's subprojects
# PowSyBl's readthedocs subprojects

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a title related to release train.

docs/index.md Outdated
- [powsybl-dynawo](https://powsybl.readthedocs.io/projects/powsybl-dynawo)
- [powsybl-entsoe](https://powsybl.readthedocs.io/projects/entsoe)

- [pypowsybl](https://powsybl.readthedocs.io/projects/pypowsybl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a special section dedicated to Python.

docs/index.md Outdated
- [pypowsybl](https://powsybl.readthedocs.io/projects/pypowsybl)
- [pypowsybl-jupyter](https://powsybl.readthedocs.io/projects/pypowsybl-jupyter)

- [powsybl-afs](https://powsybl.readthedocs.io/projects/powsybl-afs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in a way with java repositories.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, powsybl-afs is included in "advanced features" for now!

So-Fras and others added 5 commits July 9, 2024 15:09
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @olperr1 will review the release part later. My only remark could be the "releaseTrainDependencies.png" that could be more "modern" (maybe the color is because of my browser).

@annetill
Copy link
Member

Thanks a lot, @olperr1 will review the release part later. My only remark could be the "releaseTrainDependencies.png" that could be more "modern" (maybe the color is because of my browser).

To be done in a later PR.

@annetill annetill merged commit aa6b916 into main Jul 11, 2024
3 checks passed
@annetill annetill deleted the add_subprojects branch July 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants