XIIDM writer writes generator's regulating terminal each time the connectable linked to this is not the generator in order not to lose info #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
changed the title
mathbagu
approved these changes
Dec 13, 2019
…ked to this is not the generator in order not to lose info Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
force-pushed
the
bugfix_reg_terminal_generator
branch
from
6c3f92a
to
661bce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
A generator's regulating terminal is written in a XIIDM file only if its busBreakerView bus is different to the generator's busBreakerView bus. Hence, if the regulating terminal is different to the generator's terminal but in the same busBreakerView bus, the information is lost in a round trip.
What is the new behavior (if this is a feature change)?
A generator's regulating terminal is written in a XIIDM file if the connectable linked to this regulating terminal is not the generator itself. This way, the information is not lost in a round trip, no matter the topology.