Add reactive power control mode to ratio tap changers #2758

p-arvy · 2023-10-27T09:54:02Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #2769

What kind of change does this PR introduce?

Feature: Add a regulation mode "reactive power" to ratio tap changers

What is the current behavior?

Ratio tap changers can only regulate voltage

What is the new behavior (if this is a feature change)?
Ratio tap changers can regulate either voltage or reactive power

Does this PR introduce a breaking change or deprecate an API?

Partially backward compatible as follows:

RTC regulationMode is introduced, with possible values VOLTAGE or REACTIVE_POWER. getRegulationMode / setRegulationMode
targetV becomes regulationValue, getRegulationValue / setRegulationValue
backward compatibility ensured by keeping getTargetV and setTargetV, acting as shortcuts as follows:
- setTargetV automatically switches mode to VOLTAGE (if new targetV is not NaN)
- getTargetV returns NaN if mode is not VOLTAGE

But if you have defined your own IIDM implementation, you should implement the following methods:

in your RatioTapChanger implementations:
- RegulationMode getRegulationMode()
- RatioTapChanger setRegulationMode(RatioTapChanger.RegulationMode regulationMode)
- double getRegulationValue()
- RatioTapChanger setRegulationValue(double regulationValue)

Besides, ValidationUtil.checkRatioTapChangerRegulation methods take an additional parameter: regulationMode, the regulation mode (note that targetV parameter was also renamed in regulationValue).

Other information:

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChanger.java

psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java

ucte/ucte-converter/src/main/java/com/powsybl/ucte/converter/UcteExporter.java

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportUtil.java

...onversion/src/main/java/com/powsybl/cgmes/conversion/export/SteadyStateHypothesisExport.java

...s-conversion/src/test/java/com/powsybl/cgmes/conversion/test/network/compare/Comparison.java

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChanger.java

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java

annetill · 2023-12-15T08:08:16Z

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/RatioTapChangerImpl.java

@@ -97,27 +101,63 @@ public RatioTapChangerImpl setLoadTapChangingCapabilities(boolean loadTapChangin

    @Override
    public double getTargetV() {
-        return targetV.get(network.get().getVariantIndex());
+        if (regulationMode != RegulationMode.VOLTAGE) {
+            throw new IllegalAccessError("Regulation mode must be in voltage to access to target V");


Use a constant for message.

message not needed anymore, changed to return Double.NaN if regulation mode is not voltage

loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowParameters.java

jeandemanged

mainly iIDM ser/deser-ialization to be fixed with backward compatibility support

some cleanup to do

...s-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/EquipmentExportTest.java

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChanger.java

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChangerAdder.java

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java

...low-validation/src/test/java/com/powsybl/loadflow/validation/TransformersValidationTest.java

psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java

ucte/ucte-converter/src/main/java/com/powsybl/ucte/converter/UcteExporter.java

ucte/ucte-converter/src/main/java/com/powsybl/ucte/converter/UcteImporter.java

iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/AbstractTransformerSerDe.java

iidm/iidm-serde/src/main/resources/xsd/iidm_V1_12.xsd

iidm/iidm-serde/src/main/resources/xsd/iidm_equipment_V1_12.xsd

Signed-off-by: parvy <pierre.arvy@artelys.com>

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

Signed-off-by: parvy <pierre.arvy@artelys.com>

sonarcloud · 2024-01-10T14:07:46Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarCloud

p-arvy requested review from geofjamg, annetill, Hadrien-Godard, zamarrenolm and colinepiloquet October 27, 2023 09:54

annetill added the December release label Nov 8, 2023

p-arvy mentioned this pull request Nov 10, 2023

Add reactive power control to ratio tap changers #2769

Closed

annetill removed the December release label Nov 22, 2023

zamarrenolm mentioned this pull request Nov 23, 2023

Specific flag to enable/disable static var compensator regulation #2790

Open

annetill reviewed Nov 24, 2023

View reviewed changes

iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChanger.java Outdated Show resolved Hide resolved

annetill added the IIDM label Nov 27, 2023

p-arvy changed the title ~~[WIP] Add reactive power control to ratio tap changers~~ Add reactive power control to ratio tap changers Nov 27, 2023

annetill added PR: do-not-merge new version XIIDM/JIIDM and removed IIDM PR: do-not-merge labels Nov 27, 2023

annetill added the January release label Dec 5, 2023

Hadrien-Godard reviewed Dec 7, 2023

View reviewed changes

psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java Outdated Show resolved Hide resolved

Hadrien-Godard reviewed Dec 7, 2023

View reviewed changes

psse/psse-converter/src/main/java/com/powsybl/psse/converter/TransformerConverter.java Outdated Show resolved Hide resolved

Hadrien-Godard reviewed Dec 7, 2023

View reviewed changes

ucte/ucte-converter/src/main/java/com/powsybl/ucte/converter/UcteExporter.java Outdated Show resolved Hide resolved

Hadrien-Godard approved these changes Dec 7, 2023

View reviewed changes

annetill requested changes Dec 15, 2023

View reviewed changes

p-arvy force-pushed the rtc_reactive_power_regulation branch from e445e33 to 1777df6 Compare December 18, 2023 14:10

p-arvy changed the title ~~Add reactive power control to ratio tap changers~~ [WIP] Add reactive power control to ratio tap changers Dec 18, 2023

jeandemanged self-requested a review December 19, 2023 12:43

annetill changed the base branch from main to evolution_xiidm/1.12 December 19, 2023 13:44

jeandemanged requested changes Dec 19, 2023

View reviewed changes

p-arvy commented Dec 19, 2023

View reviewed changes

iidm/iidm-serde/src/main/resources/xsd/iidm_V1_12.xsd Outdated Show resolved Hide resolved

p-arvy commented Dec 19, 2023

View reviewed changes

iidm/iidm-serde/src/main/resources/xsd/iidm_equipment_V1_12.xsd Outdated Show resolved Hide resolved

jeandemanged changed the title ~~[WIP] Add reactive power control to ratio tap changers~~ [WIP] Add reactive power control mode to ratio tap changers Jan 5, 2024

p-arvy and others added 22 commits January 10, 2024 14:27

Add lf param.

fa91688

Signed-off-by: parvy <pierre.arvy@artelys.com>

Add deprecated targetV methods to RTC.

69fe598

Signed-off-by: parvy <pierre.arvy@artelys.com>

Refactor reactive power control in rtc class.

ca930c1

Signed-off-by: parvy <pierre.arvy@artelys.com>

refactor.

5af8ab1

Signed-off-by: parvy <pierre.arvy@artelys.com>

Remove LF parameter to control reactive power.

999710e

Signed-off-by: parvy <pierre.arvy@artelys.com>

Refactor.

47c475e

Signed-off-by: parvy <pierre.arvy@artelys.com>

improve coverage.

db4c6e9

Signed-off-by: parvy <pierre.arvy@artelys.com>

refactor.

187d089

Signed-off-by: parvy <pierre.arvy@artelys.com>

Fix codesmell.

510c179

Signed-off-by: parvy <pierre.arvy@artelys.com>

Add ser/deser-ialization.

5528b36

Signed-off-by: parvy <pierre.arvy@artelys.com>

Refactor taking into account comments.

6522f06

Signed-off-by: parvy <pierre.arvy@artelys.com>

Add regulationMode/value in xsd files.

69ad89c

Signed-off-by: parvy <pierre.arvy@artelys.com>

remove mandatory value for regulationMode.

d9f2cda

Signed-off-by: parvy <pierre.arvy@artelys.com>

wip.

89453b3

Signed-off-by: parvy <pierre.arvy@artelys.com>

modify xml/xiidm ressources with 1.12 iidm version.

3155983

Signed-off-by: parvy <pierre.arvy@artelys.com>

wip.

9daf06e

Signed-off-by: parvy <pierre.arvy@artelys.com>

refactor.

adacbfd

Signed-off-by: parvy <pierre.arvy@artelys.com>

proposal

0878a16

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

clean

7d277fe

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

Add TU for REACTIVE_POWER regulation mode.

26320b1

Signed-off-by: parvy <pierre.arvy@artelys.com>

Fix codesmell.

848f4c1

Signed-off-by: parvy <pierre.arvy@artelys.com>

Refactor.

3ffa7c5

Signed-off-by: parvy <pierre.arvy@artelys.com>

olperr1 force-pushed the rtc_reactive_power_regulation branch from bfcbf77 to 3ffa7c5 Compare January 10, 2024 13:56

olperr1 merged commit d6a7932 into main Jan 10, 2024
6 checks passed

olperr1 deleted the rtc_reactive_power_regulation branch January 10, 2024 15:02

olperr1 mentioned this pull request Jan 10, 2024

Refactor the tap changer adder interfaces #2828

Merged

7 tasks

olperr1 added the Breaking Change API is broken label Jan 16, 2024

jeandemanged mentioned this pull request Jan 19, 2024

Transformer RatioTapChanger reactive power control powsybl/powsybl-open-loadflow#907

Merged

3 tasks

jeandemanged mentioned this pull request Jan 29, 2024

Improve network and extension existing documentation and January 2024 updates powsybl/powsybl.github.io#303

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reactive power control mode to ratio tap changers #2758

Add reactive power control mode to ratio tap changers #2758

p-arvy commented Oct 27, 2023 •

edited by olperr1

Loading

annetill Dec 15, 2023

jeandemanged Jan 5, 2024

jeandemanged left a comment

sonarcloud bot commented Jan 10, 2024

Add reactive power control mode to ratio tap changers #2758

Add reactive power control mode to ratio tap changers #2758

Conversation

p-arvy commented Oct 27, 2023 • edited by olperr1 Loading

annetill Dec 15, 2023

Choose a reason for hiding this comment

jeandemanged Jan 5, 2024

Choose a reason for hiding this comment

jeandemanged left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jan 10, 2024

Quality Gate passed

p-arvy commented Oct 27, 2023 •

edited by olperr1

Loading