New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup to correct issues reported by Sonar (Severity: high - part 1) #2971

Merged

olperr1 merged 104 commits into main from nro/cleanup_severity_high_1

Apr 25, 2024

Member

rolnico commented Apr 10, 2024 •

edited

Loading

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?
Follows #2967 for issues:

identified as high severity
in action, ampl-converter or cgmes modules

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

rolnico added 30 commits

April 5, 2024 15:42


          add test to avoid NullPointerException

625fd76

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          fix return statement in MergedBus

5c8d233

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          add test to avoid potential ArrayIndexOutOfBoundsException

6f77f25

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          BREAKING CHANGE - Change JsonTypeInfo to avoid unsafe Jackson deseria…

624c337

…lization https://rules.sonarsource.com/java/RSPEC-4544/

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          fix GeneratorModificationActionTest

aa523f1

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          remove peek usage

489d5ff

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          remove duplicated tests

c5d232c

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          remove exceptions not thrown

05de80b

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          if simplifications

7f23910

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          removed unused methods

bcd721f

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          use Supplier from java instead if guava

21da610

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          use Supplier from java instead if guava

b3ce26c

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          ParsingContext declared final

9867b6d

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          XmlStaxContext declared final

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          replaced deprecated method for ZipFile with SeekableByteChannel

266e337

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          swapped from deprecated org.apache.commons.compress.utils.IOUtils to …

1a38ad6

…org.apache.commons.io.IOUtils

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          removed deprecated .newInstance method call

0afcfbc

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          EmptyModuleConfigRepository declared final

e81dc90

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          removed old deprecated methods + replaced guava supplier by java supp…

8541b77

…lier

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          replaced deprecated Zipfile constructor by builder

d836935

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          replaced supplier

59fd06e

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

fix

d7a6662

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

fix

06cbf2c

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          fix StandardCharsets.UTF_8

0e3d1b7

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

fix

4e1cf4a

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

fix

7a8c0eb

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          replace supplier

af70c7f

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          replace ZipFile by builder

05235c0

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          catch Exception instead of Throwable

afe04ce

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          group logic in createComputationManager for shortTime and longTime co…

f5ef925

…mputationManager

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

rolnico added 6 commits

April 11, 2024 10:09


          reduce method complexity

dbfd45a

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

11ad702

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          constant instead of duplicated String

fe8527a

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          Remove usage of generic wildcard type.

f31770f

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

484a868

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

e616aa0

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

rolnico changed the title ~~Code cleanup to correct issues reported by Sonar (Severity: high)~~ Code cleanup to correct issues reported by Sonar (Severity: high - part 1)

rolnico added 5 commits

April 11, 2024 11:05


          reduce method complexity

14c4ea1

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

04377b0

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

badf4ae

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

90e044b

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          reduce method complexity

d3636f0

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>

rolnico mentioned this pull request

Code cleanup to correct issues reported by Sonar (Severity: high - part 2) #2974

Merged

7 tasks

rolnico self-assigned this

rolnico marked this pull request as ready for review

April 11, 2024 14:54

rolnico mentioned this pull request

Code cleanup to correct issues reported by Sonar (Severity: high - part 3) #2981

Merged

7 tasks

rolnico and others added 2 commits

April 16, 2024 08:40


          switch conditions

bd66190

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          Merge branch 'main' into nro/cleanup

6665e3d

zamarrenolm self-requested a review

April 23, 2024 10:22

zamarrenolm added 2 commits

April 23, 2024 14:37


          Merge branch 'nro/cleanup' into nro/cleanup_severity_high_1

e4099cd

Signed-off-by: Luma <zamarrenolm@aia.es>


          rename method

a5a4af6

Signed-off-by: Luma <zamarrenolm@aia.es>

zamarrenolm approved these changes

View reviewed changes

Base automatically changed from nro/cleanup to main

April 24, 2024 13:27

rolnico and others added 4 commits

April 24, 2024 15:34


          Merge branch 'refs/heads/main' into nro/cleanup_severity_high_1

b7a4489

# Conflicts:
#	cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/TransformerConversionTest.java
#	commons/src/main/java/com/powsybl/commons/config/ComponentDefaultConfig.java
#	computation/src/main/java/com/powsybl/computation/DefaultComputationManagerConfig.java
#	iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/XMLImporter.java
#	loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationUtils.java
#	loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/io/AbstractValidationFormatterWriter.java
#	psse/psse-converter/src/main/java/com/powsybl/psse/converter/PsseExporter.java
#	time-series/time-series-api/src/main/java/com/powsybl/timeseries/TimeSeriesMetadata.java


          fix import

479ff1d

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>


          common code to add steps for ratio tap changers

e490a20

Signed-off-by: Luma <zamarrenolm@aia.es>


          Merge branch 'main' into nro/cleanup_severity_high_1

sonarcloud bot commented Apr 24, 2024

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

olperr1 merged commit 1c69900 into main

6 checks passed

olperr1 deleted the nro/cleanup_severity_high_1 branch

April 25, 2024 07:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet