Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OmegaRefGenerator to SynchronizedGenerator #224

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 19, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Renaming

What is the current behavior?

OmegaRefGenerator

What is the new behavior (if this is a feature change)?
SynchronizedGenerator, a more explicit name

Does this PR introduce a breaking change or deprecate an API? yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

@flo-dup flo-dup added the Breaking Change API is broken label May 19, 2023
flo-dup and others added 2 commits June 8, 2023 13:58
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Lisrte Lisrte merged commit d6984ee into main Jun 9, 2023
6 checks passed
@Lisrte Lisrte deleted the synchronized_synchronous branch June 9, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants