Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: New branch name pattern for full Sonar analyses #275

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Jul 27, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Full sonar analyses are only performed on main and release-v** branches.

What is the new behavior (if this is a feature change)?
Full sonar analyses will also be performed for full-sonar-analysis-** branches.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

This PR is not sufficient. To have full sonar analyses on these branches, the pattern must also be added to the "long-living branches" definition in the SonarCloud project.
(To have a full report, the analysis must be performed on a branch and not a PR - this is the purpose of this PR - AND the branch must be a long-living one.)

Workflow:

  • The developer creates and pushes a full-sonar-analysis-** branch
  • No PR is needed: the CI is automatically launched
  • The corresponding workflow run can be found in the Github project's "Actions" tab
  • Once the run is completed, the report can be found in the SonarCloud project's "Branches" tab
  • The developer can then push new commits on the branch, create a PR and merge it
  • The creator of the branch is responsible of the report's deletion in SonarCloud (project's "Branches" tab) since long-living branches' reports won't be automatically deleted by SonarCloud.

Sources:

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 requested a review from So-Fras July 27, 2023 15:41
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flo-dup flo-dup merged commit 0d40de4 into main Sep 13, 2023
6 checks passed
@flo-dup flo-dup deleted the allow_full_sonar_analysis branch September 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants