Extension versioning #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
force-pushed
the
extension-versioning
branch
from
ad8ab79
to
862f297
Compare
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
mathbagu
force-pushed
the
extension-versioning
branch
from
862f297
to
0b19d6b
Compare
added 4 commits
April 23, 2020 12:46
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
sebalaig
reviewed
Apr 24, 2020
include/powsybl/iidm/converter/xml/AbstractExtensionXmlSerializer.hpp
Outdated
Show resolved
Hide resolved
sebalaig
reviewed
Apr 24, 2020
sebalaig
reviewed
Apr 24, 2020
src/iidm/converter/xml/AbstractVersionableExtensionXmlSerializer.cpp
Outdated
Show resolved
Hide resolved
sebalaig
reviewed
Apr 24, 2020
test/iidm/converter/xml/IdentifiableExtensionXmlSerializerTest.cpp
Outdated
Show resolved
Hide resolved
sebalaig
reviewed
Apr 24, 2020
| void assertExtendable(const stdcxx::Reference<Extendable>& extendable) const override; | ||
|
|
||
| private: | ||
| stdcxx::CReference<Terminal> m_terminal; |
There was a problem hiding this comment.
It looks like a std::reference_wrapper can be used instead.
sebalaig
reviewed
Apr 24, 2020
sebalaig
reviewed
Apr 24, 2020
sebalaig
approved these changes
Apr 24, 2020
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mathbagu
pushed a commit
that referenced
this pull request
May 4, 2020
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
5 tasks
mathbagu
pushed a commit
that referenced
this pull request
Jun 11, 2020
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
mathbagu
pushed a commit
that referenced
this pull request
Jun 11, 2020
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
mathbagu
pushed a commit
that referenced
this pull request
Jun 17, 2020
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#28
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
The extension are always read/write in the current version
What is the new behavior (if this is a feature change)?
This version prepare the support of the versioning in the extension. An extension can now have several XML serialization depending on the version.
We also refactor the IIDM tests to separate the test of the grid model and the test relative to the XIIDM serialization. We also introduce a new extension library with 3 extensions for unit testing.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)