Improvement of the code coverage #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Baptiste Heyberger <jean-baptiste.heyberger@rte-france.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
…does not have an impact Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
…va class for more genericity in the AdmittanceLinearResolution Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
…ution.java to have a clear separation between Admittance System to be solved and Impedance Resolution which provides the result of the inversion of the admittance system Signed-off-by: Jean-Baptiste Heyberger <jbheyberger@gmail.com> Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
reviewed
Aug 7, 2022
| */ | ||
| public class CalculationLocation { | ||
|
|
||
| private final String busLocation; |
|
|
||
| private final String busLocation; | ||
|
|
||
| private final String busLocationBiPhased; |
|
|
||
| private final String busLocationBiPhased; | ||
|
|
||
| private final boolean voltageUpdate; |
There was a problem hiding this comment.
it should be used later
| @@ -472,7 +472,7 @@ private void defineZones(LfNetwork network) { | |||
| } | |||
|
|
|||
| // Example to compute full sytem nodal current injectors I = Y*V | |||
| public void computeCurrentInjections(AdmittanceEquationSystem.AdmittanceType admittanceType) { | |||
| /*public void computeCurrentInjections(AdmittanceEquationSystem.AdmittanceType admittanceType) { | |||
There was a problem hiding this comment.
I commented it because it is not used and decreases the code coverage, I can try to put it in a test in a next commit
| if (Math.abs(gSum) > epsilon || Math.abs(bSum) > epsilon) { | ||
| double det = 1 / (gSum * gSum + bSum * bSum); | ||
| if (Math.abs(gSum) > EPSILON || Math.abs(bSum) > EPSILON) { | ||
| double det = 1 / (gSum * gSum + bSum * bSum); |
There was a problem hiding this comment.
Probably a Sonar false positive, because of the previous check it cannot be zero.
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
|
SonarCloud Quality Gate failed.
|
geofjamg
approved these changes
Aug 7, 2022
geofjamg
pushed a commit
that referenced
this pull request
Sep 9, 2022
Signed-off-by: JB-H <jbheyberger@gmail.com> Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JB-H jbheyberger@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)