This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
Yes fixes #28
What kind of change does this PR introduce?
Feature / bug fix
Does this PR introduce a breaking change or deprecate an API? Yes
Other information:
Loops are placed between non-loop edges if enough place, one in each interval if possible. If not the circle is divided in nbLoops part, starting in the middle of the largest interval. Loop aperture can be changed in
SvgParameters
. See for instance the 3 different cases in the unit tests:Loop aperture = 60°, enough place to put each loop in a separated interval:
Loop aperture = 80°, not enough place to put loops in separated intervals, but enough place in the largest interval to put them all:
Loop aperture = 100°, not enough place in the intervals, therefore dividing the circle in 2, starting in the middle of the largest interval: