Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] GraalVM JDK 21 #669

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

[WIP] GraalVM JDK 21 #669

wants to merge 52 commits into from

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Oct 27, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

JDK version update

What is the current behavior?

In order to use '--pgo-instrument -H:+ProfilingEnableProfileDumpHooks' to instrument for PGO a shared library we need to upgrade to JDK 21. This is not supported with JDK 17.
But there is an issue in JDK 21 that does not allow to use native image with the class path oracle/graal#7712. So we need to wait for a fix or a workaround.
Another issue that have to be solved for upgrading to JDK21: oracle/graal#7759

24/08/04 Still same error with JDK22

Error: Expected Object but got Word for call argument in com.powsybl.python.network.NetworkCFunctions.setWorkingVariant(NetworkCFunctions.java:376). One possible cause for this error is when word values are passed into lambdas as parameters or from variables in an enclosing scope, which is not supported, but can be solved by instead using explicit classes (including anonymous classes).

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@geofjamg
GraalVM JDK 21
248d927 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
9fda9c1 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
0adb2ca 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
139e2de 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
65bba7f 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
970136d 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
EtienneLt
EtienneLt reviewed Nov 2, 2023
View reviewed changes
java/pom.xml
@@ -61,9 +61,9 @@
<version>1.1.0-SNAPSHOT</version>

<properties>
<java.version>17</java.version>
<java.version>21</java.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem with maven version ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will revert this to 17 in this pr to keep java 17 source compatibility, even using jdk 21

@geofjamg
Wip
6f80e05 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
9966bf2 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
7469bf7 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Wip
1dd696d 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Merge branch 'main' into graalvm_jdk21
11c7d1a 
# Conflicts:
#	README.md
@geofjamg
Merge branch 'main' into graalvm_jdk21
46f4ec9
@geofjamg
Merge branch 'main' into graalvm_jdk21
d32afa3 
# Conflicts:
#	cpp/CMakeLists.txt
@geofjamg
Merge
2eb0e2a 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Fix
fcf2181 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg changed the title [WIP] GraalVM JDK 21 [WIP] GraalVM JDK 22 Aug 24, 2024
@unetablettedechocolat @geofjamg
Edge info displayed (#773)
947af39 
* add parameter : edge_info_displayed
---------

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
@colinepiloquet @geofjamg
remove deprecated attributes in network modification functions (#732)
d605170 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@unetablettedechocolat @geofjamg
add Sld parameters in doc (#775)
6c2002a 
* add Sld parameters in doc
---------

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
@geofjamg
Upgrade to PowSyBl 2024.1.2 (#783)
ba28c19 
* Upgrade to PowSyBl 2024.1.2
---------

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Clean doc setup (#784)
6f652f9 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
CI should fail in case of doc generation warnings (#787)
ca23cfd 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Remove debug prints (#788)
260fc95 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@jeandemanged @geofjamg
Add support of dc_power_factor Load Flow Parameter (#756)
3901818 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged @geofjamg
Fix CI manylinux (#794)
432b597 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged @geofjamg
Add DanglingLine boundary side P, Q, Vmag, Vangle (#792)
c326d29 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@EtienneLt @geofjamg
adding documentation for reduce function (#791)
6cf3c61 
---------

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@unetablettedechocolat @So-Fras @geofjamg
Add get_matrix_multi_substation_single_line_diagram (#781)
293d066 
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
@HugoKulesza @geofjamg
Bump to v1.6.0
212530c 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza @geofjamg
Bump to v1.7.0-SNAPSHOT
462e81a 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@unetablettedechocolat @So-Fras @geofjamg
Adding current feeder info parameter for SLD (#785)
9548e88 
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
@HugoKulesza @geofjamg
Fix CI : regain compatibility with node16 for the CI (#798)
c066f58 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza @geofjamg
Fix Windows CI : set matplotlib to 3.9.0 for python > 3.8 (#801)
597cddf 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@obrix @geofjamg
Fix MSVC runtime binaries incompatibility issues (#803)
f25270c 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix @HugoKulesza @geofjamg
Do not use a constructor triggering a c++ call from within a default …
d80e776 
…parameters list, is evaluated at declaration and can trigger a call before proper pypowsybl init. (#804)

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>
@CBiasuzzi @So-Fras
@HugoKulesza @geofjamg
Fix multi substation sld svg (#797)
146e4e1 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>
@EtienneLt @geofjamg
add documentation for hvdc lines (#805)
ece090e 
---------

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@obrix @geofjamg
Rename enum related to ampl logging (#812)
076162e 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@colinepiloquet @geofjamg
Make pairing key of dangling lines updatable (#811)
493dbdc 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@unetablettedechocolat @geofjamg
Display units feeder info (#799)
eb1661e 
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
@CBiasuzzi @geofjamg
Allows empty strings in the multi-substation SLD functions' matrix pa…
e3fd8f2 
…rameter (#806)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@colinepiloquet @geofjamg
Add initial voltage plan parameter for short-circuit analysis (#809)
21c71f8 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@EtienneLt @geofjamg
Add attribute "paired" for dangling lines (#815)
f822389 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@geofjamg
Update
0e337eb 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Merge branch 'main' into graalvm_jdk21
9ea80ab
@geofjamg
Wip
5b6be19 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg
Merge branch 'main' into graalvm_jdk21
114999f
@geofjamg
Merge remote-tracking branch 'origin/graalvm_jdk21' into graalvm_jdk21
980ca17 
# Conflicts:
#	cpp/powsybl-cpp/CMakeLists.txt
@geofjamg
Wip
f2399dd 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg changed the title [WIP] GraalVM JDK 22 [WIP] GraalVM JDK 21 Sep 10, 2024
@geofjamg
Wip
29887a0 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Wip
603aeef 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Merge branch 'main' into graalvm_jdk21
13bbbb9 
# Conflicts:
#	cpp/powsybl-cpp/CMakeLists.txt
#	java/src/main/java/com/powsybl/python/network/NetworkCFunctions.java
@geofjamg
Fix
30a396c 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneLt EtienneLt EtienneLt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@geofjamg geofjamg

Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@geofjamg @EtienneLt @unetablettedechocolat @colinepiloquet @jeandemanged @HugoKulesza @obrix @CBiasuzzi