Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI : regain compatibility with node16 for the CI #798

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

HugoKulesza
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Github actions have changed the default version of node to node20 for all runners. It is not compatible with the base image used to build pypowsybl in the CI.

What is the new behavior (if this is a feature change)?
An environment variable is used to reset the version of node to node16 in the CI files.

Other information:

This workaround will only work until October, when Github intend to definitively block the use of node16.

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza HugoKulesza merged commit 1a6236b into main Jul 9, 2024
6 checks passed
@HugoKulesza HugoKulesza deleted the fix-node-version-for-ci branch July 9, 2024 08:13
HugoKulesza added a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants