Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_matrix_multi_substation_single_line_diagram #781

Conversation

unetablettedechocolat
Copy link
Contributor

@unetablettedechocolat unetablettedechocolat commented Jun 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?
feature

What is the current behavior?

Only the write_matrix_multi_substation_single_line_diagram_svg write a svg of a multi-substation diagram

What is the new behavior (if this is a feature change)?
add the get_matrix_multi_substation_single_line_diagram returning a svg, usable in Jupyter Notebooks

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Tiphaine Mouminous and others added 4 commits June 26, 2024 12:24
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
… in tests

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
@unetablettedechocolat unetablettedechocolat changed the title trying to add the matrix function add get_matrixmulti_substation_single_line_diagram Jun 26, 2024
@unetablettedechocolat unetablettedechocolat marked this pull request as ready for review June 26, 2024 14:40
@unetablettedechocolat unetablettedechocolat changed the title add get_matrixmulti_substation_single_line_diagram add get_matrix_multi_substation_single_line_diagram Jun 26, 2024
Copy link
Contributor

@CBiasuzzi CBiasuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feature! A minor thing: to be added to the docs API list, the new function should also be added to the docs/reference/network.rst file, Miscellaneous section, I think.

unetablettedechocolat and others added 3 commits July 1, 2024 17:06
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
@HugoKulesza HugoKulesza merged commit 1463ba0 into main Jul 2, 2024
6 checks passed
@HugoKulesza HugoKulesza deleted the add_get_matrix_multi_substation_single_line_diagram_svg_and_metadata branch July 2, 2024 11:46
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
geofjamg pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants