Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a logo #75

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Add a logo #75

merged 2 commits into from
Jun 3, 2024

Conversation

trexfeathers
Copy link
Collaborator

I used Microsoft Office to draw these - hence the originals are in a .xlsx file. This is not ideal, but it would take much longer to work out how to achieve the same with PyVista / manual drawing / whatever.

Also not ideal is PNG rather than SVG format. Office can produce SVGs, but when 3D perspective is applied (as in this case) the image is actually just a raster underneath.

@pp-mo
Copy link
Owner

pp-mo commented Jun 3, 2024

This is great stuff !
And very timely, since I'm hoping to push along proper docs pages quite soon.

Thanks for taking the trouble -- I'm going to add you as a contributor / maintainer (hopefully will unblock future RTD runs ?)

Copy link
Owner

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very worst, this is a great start !

Can you inject this into the main-page README also ?
I think that will improve the look of the entire project,
though I suspect it will make it even more desirable to write a better oneline project summary

@trexfeathers
Copy link
Collaborator Author

At the very worst, this is a great start !

Can you inject this into the main-page README also ? I think that will improve the look of the entire project, though I suspect it will make it even more desirable to write a better oneline project summary

I think I have done this (unless I am misunderstanding). ncdata/README.md at 5395b61 · pp-mo/ncdata (github.com)

@pp-mo
Copy link
Owner

pp-mo commented Jun 3, 2024

I think I have done this
OK I think I failed to understand this, because I stupidly followed the README link from the docs build instead of looking at the README as modified here !

Definitely good enough for now, thanks @trexfeathers

@pp-mo pp-mo merged commit dfe03ed into pp-mo:main Jun 3, 2024
2 checks passed
pp-mo pushed a commit that referenced this pull request Jun 26, 2024
* Add a logo.

* Rename logos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants