Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test_object_size on CPython 3.8 and later #140

Closed
nbraud opened this issue Mar 29, 2019 · 1 comment · Fixed by #143
Closed

Re-enable test_object_size on CPython 3.8 and later #140

nbraud opened this issue Mar 29, 2019 · 1 comment · Fixed by #143
Labels
blocked Blocked by another issue, potentially external to the project.

Comments

@nbraud
Copy link
Collaborator

nbraud commented Mar 29, 2019

Requires a fix for pympler/pympler#74
@nbraud nbraud added the blocked Blocked by another issue, potentially external to the project. label Mar 29, 2019
@nbraud nbraud mentioned this issue Mar 29, 2019
Merged
@nbraud
Copy link
Collaborator Author

nbraud commented Mar 31, 2019

Note: the bug was fixed upstream a while ago, but upstream hasn't made a release yet.

nbraud added a commit to nbraud/ppb-vector that referenced this issue Apr 6, 2019
@nbraud
tests/memory: re-enable test_object_size under CPython 3.8 & later
d8a25e8 
Requires pympler 0.7 or later, which fixes an incompatibility with CPython 3.8.

Closes ppb#140
@nbraud nbraud mentioned this issue Apr 6, 2019
Merged
bors bot added a commit that referenced this issue Apr 6, 2019
@bors @nbraud
Merge #143
e0ffe50 
143: tests/memory: re-enable test_object_size under CPython 3.8 & later r=astronouth7303 a=nbraud

Requires pympler 0.7 or later, which fixes an incompatibility with CPython 3.8.

Closes #140

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors bors bot closed this as completed in #143 Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked by another issue, potentially external to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/memory: re-enable test_object_size under CPython 3.8 & later nbraud/ppb-vector
1 participant
@nbraud