Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to uber go-mock and bump go version to 1.21 across project. #537

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Move to uber go-mock and bump go version to 1.21 across project. #537

merged 3 commits into from
Jan 2, 2024

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Jan 1, 2024

Changes:

  1. Update go version to 1.21 in workflows and in go.mod file
  2. Use uber-go/mock.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 1, 2024
@kishen-v kishen-v mentioned this pull request Jan 1, 2024
Closed
2 tasks
@kishen-v kishen-v force-pushed the move-to-uber-gomock branch 2 times, most recently from 2af4d41 to 35a2630 Compare January 2, 2024 04:50
mkumatag
mkumatag approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 0598d39 into ppc64le-cloud:main Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@bkhadars bkhadars Awaiting requested review from bkhadars

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishen-v @ppc64le-cloud-bot @mkumatag