Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocp-power-automation/ci-monitoring-automation project #431

Closed
wants to merge 1 commit into from
Closed

Add ocp-power-automation/ci-monitoring-automation project #431

wants to merge 1 commit into from

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Dec 1, 2023

No description provided.

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yussufsh
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
@yussufsh
Copy link
Contributor Author

yussufsh commented Dec 1, 2023

/cc @mkumatag

@yussufsh
Copy link
Contributor Author

yussufsh commented Dec 1, 2023

@Shilpa-Gokul

@yussufsh yussufsh mentioned this pull request Dec 1, 2023
Merged
Shilpa-Gokul
Shilpa-Gokul reviewed Dec 1, 2023
View reviewed changes
config/prow/plugins.yaml
@@ -271,3 +271,8 @@ external_plugins:
events:
- issue_comment
- pull_request
ocp-power-automation/ci-monitoring-automation:
- name: mergable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that mergeable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was a typo with the previous repo at L269 as well.
I think it has nothing to do with this plugin.
I shall get back.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact must revisit if these entries for mergeable are needed here.

@mkumatag
Copy link
Member

mkumatag commented Dec 1, 2023

@yussufsh please create PR from your fork

@mkumatag mkumatag closed this Dec 1, 2023
@mkumatag mkumatag deleted the yussufsh-patch-2 branch December 1, 2023 08:05
@mkumatag
Copy link
Member

mkumatag commented Dec 1, 2023

@yussufsh this plugin was written only to handle that +2, please avoid adding this config if you don't have +2 configured the repo

@yussufsh
Copy link
Contributor Author

yussufsh commented Dec 1, 2023

@yussufsh this plugin was written only to handle that +2, please avoid adding this config if you don't have +2 configured the repo

Then this PR is not needed for ci-monitoring-project.
I will remove others from the list in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shilpa-Gokul Shilpa-Gokul Shilpa-Gokul left review comments

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yussufsh @ppc64le-cloud-bot @mkumatag @Rajalakshmi-Girish @Shilpa-Gokul